-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch API breaks existing module and adding --no-experimental-fetch fixes the problem #1566
Labels
Comments
I've been having the same issue, this worked for me as well. Thanks! |
skaldarnar
added a commit
to MovingBlocks/movingblocks.github.com
that referenced
this issue
Jan 2, 2023
Due to octokit/request.js#526 and node-fetch/node-fetch#1566 we need to disable the experimental Fetch API introduced in Node.js 18.x.
skaldarnar
added a commit
to MovingBlocks/movingblocks.github.com
that referenced
this issue
Jan 5, 2023
…y module info (#179) - feat(source-terasology-module): custom source plugin to fetch Terasology module information - basic information: name, url, description, homepageUrl - include URL to custom `cover` image if defined - parse `module.txt` and enrich it with `tags` (also skip repos without 'module.txt' on branch 'develop') - include content of `README.md` - chore: build with `NODE_OPTIONS='--no-experimental-fetch'` to avoid warning about experimental Fetch API in Node 18.x (see octokit/request.js#526 and node-fetch/node-fetch#1566) - doc(source-terasology-module): document basic usage of the source plugin
Thanks! This saved my day! |
gastonfournier
added a commit
to Unleash/unleash
that referenced
this issue
Apr 18, 2023
## About the changes This upgrades our main branch to use node 18 which is the active LTS version and stops using node 14 which reaches the end of life in a few weeks: https://nodejs.dev/en/about/releases/ This PR also adds `--no-experimental-fetch` for frontend tests and other frontend commands. Related to: node-fetch/node-fetch#1566 More about the experimental fetch release: https://nodejs.org/en/blog/announcements/v18-release-announce#fetch-experimental
This was referenced Apr 20, 2023
filiphsps
added a commit
to filiphsps/commerce
that referenced
this issue
Jul 25, 2023
This is honestly really stupid, shouldn't be needed but oh well. See node-fetch/node-fetch#1566.
anoukhello
added a commit
to pass-culture/pass-culture-app-native
that referenced
this issue
Aug 4, 2023
lbeneston-pass
pushed a commit
to pass-culture/pass-culture-app-native
that referenced
this issue
Aug 7, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Repro steps:
node draco_nodejs_example.js
Above fails:
Adding --no-experimental-fetch fixes the issue:
Draco is tracking this here: google/draco#888
One of our users encountered it and reported it here: CesiumGS/gltf-pipeline#613
The text was updated successfully, but these errors were encountered: