Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Install geopandas using pip in the "GMT Dev Tests" workflow #2525

Merged
merged 5 commits into from
Jun 10, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 28, 2023

Description of proposed changes

Xref #2125 (comment) and #1290 (comment)

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman
Copy link
Member Author

seisman commented Apr 28, 2023

/test-gmt-dev

@seisman
Copy link
Member Author

seisman commented May 2, 2023

/test-gmt-dev

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels May 2, 2023
@seisman seisman added this to the 0.10.0 milestone May 2, 2023
@seisman seisman marked this pull request as ready for review June 9, 2023 05:16
@seisman seisman changed the title CI: Improve the "Tests Dev" workflow CI: Install geopandas using pip in the "GMT Dev Tests" workflow Jun 9, 2023
@seisman seisman added the needs review This PR has higher priority and needs review. label Jun 9, 2023
@@ -133,14 +132,6 @@ jobs:

# Pull baseline image data from dvc remote (DAGsHub)
- name: Pull baseline image data from dvc remote
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 134-139 and lines 141-146 are duplicated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks like we forgot to remove these lines in #2045.

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks @seisman. This should allow us to catch any GDAL version conflicts between GMT and geopandas/fiona, and solve them proactively on conda-forge ahead of time!

@@ -133,14 +132,6 @@ jobs:

# Pull baseline image data from dvc remote (DAGsHub)
- name: Pull baseline image data from dvc remote
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks like we forgot to remove these lines in #2045.

@seisman seisman merged commit 5d7eb3b into main Jun 10, 2023
@seisman seisman deleted the ci-tests-dev branch June 10, 2023 02:28
@seisman seisman removed the needs review This PR has higher priority and needs review. label Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants