-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Install geopandas using pip in the "GMT Dev Tests" workflow #2525
Conversation
/test-gmt-dev |
/test-gmt-dev |
@@ -133,14 +132,6 @@ jobs: | |||
|
|||
# Pull baseline image data from dvc remote (DAGsHub) | |||
- name: Pull baseline image data from dvc remote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 134-139 and lines 141-146 are duplicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looks like we forgot to remove these lines in #2045.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks @seisman. This should allow us to catch any GDAL version conflicts between GMT and geopandas/fiona, and solve them proactively on conda-forge ahead of time!
@@ -133,14 +132,6 @@ jobs: | |||
|
|||
# Pull baseline image data from dvc remote (DAGsHub) | |||
- name: Pull baseline image data from dvc remote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looks like we forgot to remove these lines in #2045.
Description of proposed changes
Xref #2125 (comment) and #1290 (comment)
Fixes #
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version