-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump GMT version from 6.2.0rc1 to 6.2.0rc2 in CI #1290
Conversation
Second release candidate of Generic Mapping Tools v6.2.0 at https://github.com/GenericMappingTools/gmt/releases/tag/6.2.0rc2.
The Python 3.9 / NumPy 1.20 build can't get past the install step (see https://github.com/GenericMappingTools/pygmt/pull/1290/checks?check_run_id=2661062442#step:5:1). I think this is due to a package conflict with |
Perhaps we can temporarily remove "geopands" so we can proceed? |
Not a big fan of this idea, but yeah we might have to. What I might do is to remove geopandas from ci_tests.yaml, but install it in ci_tests_dev.yaml (while pinning to GDAL 3.2) so that we have some tests using |
Also temporarily pinning to gdal=3.2 so that geopandas and gmt can co-exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good if all tests pass.
Well, the tests won't all pass because we need to update 24 of them 🤣 But I'm assuming we'll update those in separate PRs later 😇 |
…#1290) Second release candidate of Generic Mapping Tools v6.2.0 at https://github.com/GenericMappingTools/gmt/releases/tag/6.2.0rc2. * Bump GMT version from 6.2.0rc1 to 6.2.0rc2 in ci_tests.yaml and ci_tests_dev.yaml * Bump GMT version from 6.1.1 to 6.2.0rc2 in cache data workflow * Temporarily remove optional geopandas dependency from ci_tests.yaml * Install geopandas in ci_tests_dev.yaml Also temporarily pinning to gdal=3.2 so that geopandas and gmt can co-exist.
Description of proposed changes
Second release candidate of Generic Mapping Tools v6.2.0 at https://github.com/GenericMappingTools/gmt/releases/tag/6.2.0rc2.
Note: This PR also temporarily stops
geopandas
from being installed in the main test suite, see #1290 (comment) for the rationale.Related to #1289, Supersedes #1218
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version