Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Install geopandas using pip in the "GMT Dev Tests" workflow #2525

Merged
merged 5 commits into from
Jun 10, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions .github/workflows/ci_tests_dev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -116,14 +116,13 @@ jobs:
libnetcdf
pcre
zlib
geopandas

# Install dependencies from PyPI
- name: Install dependencies
run: |
python -m pip install --pre --prefer-binary \
numpy pandas xarray netCDF4 packaging \
build contextily dvc ipython rioxarray \
build contextily dvc geopandas ipython rioxarray \
'pytest>=6.0' pytest-cov pytest-doctestplus pytest-mpl \
sphinx-gallery

Expand All @@ -133,14 +132,6 @@ jobs:

# Pull baseline image data from dvc remote (DAGsHub)
- name: Pull baseline image data from dvc remote
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 134-139 and lines 141-146 are duplicated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks like we forgot to remove these lines in #2045.

if: github.event_name == 'schedule'
run: |
dvc pull
ls -lhR pygmt/tests/baseline/

# Pull baseline image data from dvc remote (DAGsHub)
- name: Pull baseline image data from dvc remote
if: github.event_name != 'schedule'
run: |
dvc pull
ls -lhR pygmt/tests/baseline/
Expand Down