Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context Variables UI Incorrectly Disables + Icon #5248

Closed
danieldresser-ie opened this issue Apr 12, 2023 · 3 comments
Closed

Context Variables UI Incorrectly Disables + Icon #5248

danieldresser-ie opened this issue Apr 12, 2023 · 3 comments

Comments

@danieldresser-ie
Copy link
Contributor

Version: Gaffer 1.2

Description

Create a ContextVariables node. Add a couple of entries. Set an expression on the name or value of one of the entries. Click off and on the node to refresh the UI. The + icon for adding new entries is now incorrectly greyed out and can't be clicked.

It seems like something is somehow checking if all children of the variables plug are writable when deciding whether the variables plug is writable enough that new entries can be added.

@murraystevenson
Copy link
Contributor

Funnily enough, I noticed the same behaviour today with the Spreadsheet. An expression driving the name of a row or the value of a cell also greys out the add row and add column buttons.

@boberfly
Copy link
Collaborator

Yeah I ran into this one but didn't report as I thought I saw John mention there's a fix already, that might've been on gaffer-dev I'm not sure.

@murraystevenson
Copy link
Contributor

There was an existing fix for the CompoundDataPlugValueWidget #5231 released today in 1.2.3.0, which covers this specific issue. We'll still need to address the Spreadsheet _RowsPlugValueWidget issue I mentioned.

murraystevenson added a commit to murraystevenson/gaffer that referenced this issue Apr 24, 2023
Refer to 7f7e265 and b694a48 for equivalent fixes to other widgets.

Fixes GafferHQ#5248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants