Skip to content

Commit

Permalink
SpreadsheetUI : Fix editability when a child has an input
Browse files Browse the repository at this point in the history
Refer to 7f7e265 and b694a48 for equivalent fixes to other widgets.

Fixes #5248
  • Loading branch information
murraystevenson committed Apr 27, 2023
1 parent d8439b4 commit 4889f12
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions Changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Fixes
- Arnold : Moved `distance` shader to the `Shader/Utility` section of the node menu (previously in `Shader/Other`).
- Graph Editor : Fixed a bug for some video drivers that led to a crash when using nodes with icons.
- Node Editor : Removed `Gang/Ungang` menu options from output plugs.
- SpreadsheetUI : Fixed bug which prevented the addition of new rows and columns when an existing plug had an input connection (#5248).

1.2.3.0 (relative to 1.2.2.0)
=======
Expand Down
5 changes: 4 additions & 1 deletion python/GafferUI/SpreadsheetUI/_RowsPlugValueWidget.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,10 @@ def addColumnButtonMenuSignal( cls ) :

def _updateFromEditable( self ) :

editable = self._editable() and self.getPlug().getInput() is None
# Not using `_editable()` as it considers the whole plug to be non-editable if
# any child has an input connection, but that shouldn't prevent us adding new
# rows or columns.
editable = self.getPlug().getInput() is None and not Gaffer.MetadataAlgo.readOnly( self.getPlug() )
self.__addRowButton.setEnabled( editable )
self.__addColumnButton.setEnabled( editable )

Expand Down

0 comments on commit 4889f12

Please sign in to comment.