Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompoundDataPlugValueWidget : Fix editability when a child has an input #5231

Merged
merged 1 commit into from
Mar 30, 2023
Merged

CompoundDataPlugValueWidget : Fix editability when a child has an input #5231

merged 1 commit into from
Mar 30, 2023

Conversation

johnhaddon
Copy link
Member

This is basically the same bug as 7f7e265.

@johnhaddon johnhaddon requested a review from ericmehl March 29, 2023 14:41
@johnhaddon johnhaddon self-assigned this Mar 29, 2023
ericmehl
ericmehl approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@ericmehl ericmehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The test failure seems to be a timeout on the debug build that I don't expect to be a 🚩

@johnhaddon johnhaddon changed the base branch from main to 1.2_maintenance March 30, 2023 08:21
@johnhaddon johnhaddon merged commit 4ed4f24 into GafferHQ:1.2_maintenance Mar 30, 2023
@johnhaddon johnhaddon deleted the compoundDataPlugValueWidgetFix branch April 12, 2023 09:00
@murraystevenson murraystevenson mentioned this pull request Apr 14, 2023
Closed
@murraystevenson murraystevenson mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericmehl ericmehl ericmehl approved these changes

Assignees

@johnhaddon johnhaddon

Labels
None yet
Projects
Work in Progress
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnhaddon @ericmehl