360 refactor relaxometry

[sophie22]

part 1: simplify existing functions and make them more explicit

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
hazenlib
HazenTask.py	26	3	88%	32–34
__init__.py	54	17	69%	125–133, 145, 179–181, 184–186, 193–196, 207
exceptions.py	21	4	81%	17–21
relaxometry.py	286	86	70%	182–200, 377, 423–425, 492, 566–588, 606–621, 1037–1040, 1046–1052, 1085–1130
utils.py	189	43	77%	61, 65, 75, 80, 117, 124–129, 140, 143–150, 170–172, 190–192, 211–213, 222, 227, 233, 284, 287, 295–300, 303, 346, 355, 371
hazenlib/tasks
acr_geometric_accuracy.py	146	56	62%	38–75, 179–195, 209–233
acr_ghosting.py	117	43	63%	33–55, 93–95, 125–127, 163–196
acr_slice_position.py	155	54	65%	53–76, 154, 215–260
acr_slice_thickness.py	154	64	58%	40–62, 188–243
acr_snr.py	141	62	56%	34–78, 103, 172–182, 215–228, 261–274
acr_spatial_resolution.py	244	74	70%	66–90, 169, 212, 225–234, 323–378
acr_uniformity.py	90	33	63%	34–56, 123–140
ghosting.py	152	53	65%	18–35, 50, 112–113, 117, 127–128, 154–156, 173–175, 221–259
relaxometry.py	7	7	0%	1–11
slice_position.py	117	23	80%	28, 37–38, 49, 103–104, 130, 210, 217–234
slice_width.py	360	53	85%	34–37, 41, 109, 168–188, 453, 458–459, 465, 470, 532–533, 782–823
snr.py	166	67	60%	51, 68–73, 167–185, 200–209, 227–237, 264–274, 279–289, 320–333, 338–346, 375–388
snr_map.py	104	1	99%	291
spatial_resolution.py	248	45	82%	36–39, 43, 64, 149, 208, 334–370
uniformity.py	79	20	75%	42–45, 51, 93–94, 101, 135–149
TOTAL	2881	808	72%

Tests	Skipped	Failures	Errors	Time
215	0 💤	0 ❌	0 🔥	3m 2s ⏱️

[sophie22]

Part 1: simplification and adjusting unit tests is COMPLETE

TODO: consider adding back time_attribute to be an object attribute so it doesn't have to be passed each time, especially in the unit tests.

[tomaroberts]

Looks good – I've made a minor change to the filename. "config" is quite a loaded programming term in repos, normally indicates a file responsible for controlling parameters that you might want to adjust/not hard-code. Given the config.py was just predominantly parameters for the relaxometry Task, I've just updated the filename to reflect that.

[sophie22]

I was planning to move other parameters like ROI sizes and default/template values used in other tasks to the config file, but can still rename this file later if the move does happen.

[sophie22]

I have 4 more commits that ended up not being pushed, I apologise. Will open a new PR