Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.8.0.beta.1 #1947

Merged
merged 251 commits into from
Nov 13, 2024
Merged

Release v0.8.0.beta.1 #1947

merged 251 commits into from
Nov 13, 2024

Conversation

scottqueen-bixal
Copy link
Collaborator

@scottqueen-bixal scottqueen-bixal commented Nov 13, 2024

PR Summary

https://github.com/GSA/px-benefit-finder/milestone/14?closed=1

Related Github Issue

Application Improvements

NEW FEATURE | Return to first step of form, without clearing the form #1473
NEW FEATURE | client side routing in embedded applications #1831
TEST | NGINX redirects for client side routing fallback #1838
Form-page-2 page change event firing twice #1786
Remove crazyegg script value updates from application #1811

Custom Module Improvements

Enable worflow for Benefit Finder nodes that can be in draft #1710
No JSON file generation for moderation state Needs Review #1846
prevent agency archived if still used #1847
Do not use archived content in building JSON data #1858
display raw html #1817
Do not archive criteria if still used #1866
do not archive life event form if still used #1902
Do not archive criteria if still used #1866
Get AJAX HTTP error in JSON file generation when creating new life event #1770

DataLayer Improvements

Remove data-analytic* attributes from DOM

Design Improvements

Centering select an option modal text & buttons #1891


Detailed Testing steps

NEW FEATURE | Return to first step of form, without clearing the form #1473
NEW FEATURE | client side routing in embedded applications #1831

  • update nginx config,
  • add the following redirects to usagov-2021/.docker/src-cms/etc/nginx/partials/internal_redirects.conf
 rewrite ^/benefit-finder/([^/]+)/[^/]+$ /benefit-finder/$1 permanent;
 rewrite ^/es/buscador-beneficios/([^/]+)/[^/]+$ /es/buscador-beneficios/$1 permanent;
  • uncomment include partials/internal_redirects.conf; in usagov-2021/.docker/src-cms/etc/nginx/partials/cms.conf.tmpl
    include partials/drupal.conf;
    ## un-comment this to test internal redirects
    ## (which should match the corresponding internal_redirects.conf in src-www):
    include partials/internal_redirects.conf;
  • rebuild docker containers
  • navigate to /benefit-finder/death on localhost

NEW FEATURE | client side routing in embedded applications #1831

  • CLICK 'Start...`
  • include values for required fields for both form steps
  • CLICK the back button in the browser
  • ensure user can navigate back to beginning of form
  • CLICK the forward button in the browser
  • ensure user can navigate back to second step of form
  • ensure data entered is still present in values of fieldsets
  • CLICK continue
  • CLICK "Get your results"
  • ensure zero benefits view
  • re-test in es

NEW FEATURE | Return to first step of form, without clearing the form #1473

  • CLICK "Go back to form"
  • ensure you are on step one of form
  • answer yes to radios
  • in modal, CLICK view "Review your selections"
  • CLICK "Next"
  • Ensure eligible results view
  • CLICK "Explore other potential benefits"
  • Ensure not-eligible view
  • CLICK the back button in the browser
  • Ensure eligible results view
  • CLICK `Share link"
  • paste link in browser URL
  • ensure alert for unsaved changes
Screenshot 2024-10-10 at 11 22 52 AM
  • Ensure eligible results view
  • CLICK "Clear my answers..."

TEST | NGINX redirects for client side routing fallback #1838

  • Ensure intro view
  • CLICK 'Start...`
  • Ensure child path of life event is form step heading, ie. /death/about-you
  • enter data for first form question
  • refresh page
  • ensure alert for unsaved changes
  • Ensure intro view

Form-page-2 page change event firing twice #1786

  • navigate to /disability
  • CLICK start
  • CLICK next
  • resolve error
  • CLICK next
  • CLICK next
  • CLICK verify
  • console.log(window.dataLayer)
  • ensure that bf_page_change event for modal and form page 2 only fired once
Screenshot 2024-10-10 at 11 45 01 AM

Custom Module Improvements

Get AJAX HTTP error in JSON file generation when creating new life event #1770

To test in local development site or in dev site.

  • Pull changes locally
  • Make local development site up at http://localhost
  • Navigate to add/bears_life_event to create a new life event
  • Input Title: New Life Event
  • Input ID: new_life_event
  • Save as Draft
  • Navigate to admin/content?combine=&type=bears_criteria&status=All&langcode=All
  • Go to criteria "Applicant date of birth" edit page
  • Edit title
  • Save as Draft
  • Verify the system generates JSON files successfully without Ajax HTTP error
[Do not archive criteria if still used](https://github.com//issues/1866) https://github.com//issues/1866
  • Navigate to admin/content?combine=&type=bears_criteria&status=All&langcode=All
  • Go to criteria "Applicant date of birth" edit page
  • Change to Archived
  • CLICK Save
  • Verify error message with list of benefits and life event forms that use this criteria

do not archive life event form if still used #1902

  • Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
  • Go to life event form "Benefit finder: death of a loved one" edit page
  • Change to Archived
  • CLICK Save
  • Verify error message

Enable worflow for Benefit Finder nodes that can be in draft #1710

  • Navigate to node/add
  • CLICK Agency
  • Create an agency
  • Save as "Draft
  • CLICK "Edit"
  • Save as "Needs Review"
  • CLICK "Edit"
  • Save as Published
  • CLICK "Edit"
  • Save as Archived
  • CLICK "Edit"
  • Save as Draft

No JSON file generation for moderation state Needs Review #1846

  • Navigate to admin/content?combine=&type=bears_agency&status=All&langcode=All
  • Go to agency "Department of Education (DOE)" edit page
  • Change to Draft
  • CLICK Save
  • Verify JSON file generation
  • Go to agency "Department of Education (DOE)" edit page
  • Change to Needs Review
  • CLICK Save
  • Verify no JSON file generation
  • Verify seeing warning message

prevent agency archived if still used #1847

  • Navigate to admin/content?combine=&type=bears_agency&status=All&langcode=All
  • Go to agency "Social Security Administration (SSA)" edit page
  • Change to Archived (unpublished)
  • CLICK Save button
  • Verify error message with list of benefits that use the agency

Do not use archived content in building JSON data #1858

To test in local development site or in dev site.

  • Navigate to benefit-finder/api/life-event/death
  • Verify benefit "COVID-19 funeral assistance" in JSON data
  • Navigate to admin/content?combine=COVID&type=bears_benefit&status=All&langcode=All
  • Go to benefit "COVID-19 funeral assistance" edit page
  • Change to archived
  • CLICK Save
  • Navigate to benefit-finder/api/life-event/death
  • Verify no benefit "COVID-19 funeral assistance" in JSON data

display raw html #1817

To test in local development site or in dev site.

  • navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
  • go to life event form "Benefit finder: retirement" edit page
  • add <a href="http://usagov.gov">USAGov</a> in summary field
  • save as published
  • navigate to benefit-finder/api/life-event/retirement
  • verify the hyperlink in summary as raw html

DataLayer Improvements

Remove data-analytic* attributes from DOM

  • navigate through app providing values
  • On results page, inspect DOM
  • ensure the following data attributes have been updated
data-analytics* 
data-analytics-content*

have been removed or replaced by

data-test-results-view*

Design Improvements

Centering select an option modal text & buttons #1891

  • navigate to modal step
  • zoom window to '500%'
  • zoom window to '40%'
  • ensure content remains centered

expected:

Screen.Recording.2024-11-05.at.9.53.29.AM.mov

scottqueen-bixal and others added 30 commits September 4, 2024 12:12
…com:GSA/px-benefit-finder into 1567-data-attributes-in-selectors
PXBF-1703-clean-cy-script-commands: clean up cy script commands
Xavier Metichecchia and others added 27 commits October 30, 2024 10:16
Release v0.8.0.beta.1 (Sprint 43)
Remove duplicate test id locator
…com:GSA/px-benefit-finder into 1567-data-attributes-in-selectors
Content changes Oct '24
Spanish content changes Oct '24
…ttributes-in-selectors of github.com:GSA/px-benefit-finder into 1567-data-attributes-selectors-updated
…ttributes-selectors-updated of github.com:GSA/px-benefit-finder into 1567-data-attributes-selectors-updated
PXBF-1567-data-attributes-in-selectors: 1567 data attributes in selectors
Release v0.8.0.beta.1 (Sprint 44)
Automated PR from update-submodule-hash-b65730e to main
@scottqueen-bixal scottqueen-bixal changed the title Main Release v0.8.0.beta.1 Nov 13, 2024
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review November 13, 2024 18:32
@github-actions github-actions bot merged commit 005f6f9 into release Nov 13, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants