Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form-page-2 page change event firing twice #1786

Closed
nickpistone opened this issue Sep 6, 2024 · 4 comments · Fixed by #1801 or #1834
Closed

Form-page-2 page change event firing twice #1786

nickpistone opened this issue Sep 6, 2024 · 4 comments · Fixed by #1801 or #1834
Assignees
Labels
bug Something isn't working
Milestone

Comments

@nickpistone
Copy link
Collaborator

What's expected

Each time the virtual page changes, one bf_page_change data layer event should fire

What happened

When the second page is submitted and you get to the modal, you also get an additional page_change event for bf-form-2. So it's like the second form page is reloading when you submit it and you end up with a virtual pageview for the modal as well as two virtual pageviews for bf-form-2 preceding it.

How to replicate

Go to /disability and go through the pages until you get to the modal. Check the data layer on every page, and you will see that an extra page_change event fires when you click to submit bf-form-2 (More about you).

@nickpistone nickpistone added the bug Something isn't working label Sep 6, 2024
@scottqueen-bixal
Copy link
Collaborator

confirming that I can reproduce this in /death

Screenshot 2024-09-06 at 11 17 24 AM

@nickpistone
Copy link
Collaborator Author

Just tested this on /disability and I still see 2 page change events for bf-form-2.

@scottqueen-bixal
Copy link
Collaborator

during deployment technical testing, we found that this fix was inconsistent and needs additional work. Will release as next patch.

@nickpistone
Copy link
Collaborator Author

Tested here: https://bf-cms-main.bxdev.net/benefit-finder/disability
Verified that the page_change event is no longer double firing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants