Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benefit Finder v0.7.0.beta.1 (Sprint 40) #1827

Merged
merged 50 commits into from
Sep 18, 2024
Merged

Benefit Finder v0.7.0.beta.1 (Sprint 40) #1827

merged 50 commits into from
Sep 18, 2024

Conversation

scottqueen-bixal
Copy link
Collaborator

@scottqueen-bixal scottqueen-bixal commented Sep 18, 2024

PR Summary

Related Github Issue

Application Improvements

beforeunload event not handling full data object #1816

Content Improvements

Stray HTML on "Explore other potential benefits" page #1814
Add display order field in life event #1795

Data Improvements

Form-page-2 page change event firing twice #1786

a11y Improvements

a11y - Modal Zoom Scaling #1585

Detailed Testing steps

Application Improvements

beforeunload event not handling full data object #1816

  • navigate to /death
  • enter data for first step of form
  • CLICK back button in browser
  • expect to see an alert
  • cancel
  • complete required fields in first step of form
  • navigate to second step
  • CLICK back button in browser
  • expect to see an alert
  • repeat for steps to test on results page

Content Improvements

Stray HTML on "Explore other potential benefits" page #1814

  • complete form with required fields and answer yes to others
  • on results view CLICK, "Explore other potential benefits"
  • ensure closing </p> tag is not rendered in string

reported:
Screenshot 2024-09-17 at 10 33 36 AM

expected:
Screenshot 2024-09-17 at 10 27 47 AM
Screenshot 2024-09-17 at 10 29 04 AM

Add display order field in life event #1795

  • navigate to admin/content?combine=&type=bears_life_event&status=All&langcode=All
  • go to life event "Benefit finder: death of a loved one" edit page
  • verify that it has Display Order field

Data Improvements

Form-page-2 page change event firing twice #1786

  • navigate to disability
  • CLICK start
  • CLICK next
  • resolve error
  • CLICK next
  • CLICK next
  • console.log(window.dataLayer)
  • ensure that bf_page_change event for modal and form page 2 only fire once

expected:

Screenshot 2024-09-12 at 12 41 43 PM

a11y Improvements

a11y - Modal Zoom Scaling #1585

  • navigate to /benefit-finder/death -> modal view step
  • ensure modal overlay sits above usagov global elements

expected
Screenshot 2024-09-12 at 11 51 25 AM

  • zoom browser window to 400%
  • ensure close, title, and both nav buttons are in the view

expected
Screenshot 2024-09-12 at 11 51 08 AM

gchi25 and others added 30 commits August 26, 2024 13:18
1795 add display order field in life event node
PXBF-1585-fix-modal-zoom: update modal scale and position
scottqueen-bixal and others added 20 commits September 12, 2024 17:37
PXBF-1786-fix-bf-change-event: async data handling in modal
PXBF-1767-remove-component-tests: remove component tests
Revert PR 1667 "Revert PR 1663 update check data controller dependency injection"
1769 set link field of relevant benefit as required
PXBF-1814-fix-ui-markup: update closing p tag in description
PXBF-1816-fix-beforeunload-event: determine if form has value based o…
@scottqueen-bixal scottqueen-bixal changed the title Benefit Finder v0.7.0.beta.1 Benefit Finder v0.7.0.beta.1 (Sprint 40) Sep 18, 2024
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review September 18, 2024 16:08
@scottqueen-bixal scottqueen-bixal merged commit a312cc9 into main Sep 18, 2024
15 checks passed
@gchi25
Copy link
Collaborator

gchi25 commented Sep 18, 2024

Tested. Worked as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants