-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.7.0.beta.1 #1843
Merged
Merged
Release v0.7.0.beta.1 #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PXBF-1786-fix-bf-change-event: async data handling in modal
PXBF-1767-remove-component-tests: remove component tests
1479 delete benefit message
Revert PR 1667 "Revert PR 1663 update check data controller dependency injection"
1799 asset path alias
1769 set link field of relevant benefit as required
…n selected values in data array
PXBF-1814-fix-ui-markup: update closing p tag in description
PXBF: fix lint error
PXBF-1816-fix-beforeunload-event: determine if form has value based o…
Benefit Finder v0.7.0.beta.1 (Sprint 40)
scottqueen-bixal
requested review from
nehemiah-abuga,
gchi25 and
XavierMetichecchia
October 2, 2024 14:18
nehemiah-abuga
approved these changes
Oct 2, 2024
gchi25
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested display order in life event. Worked as expected.
Tested link as required in relevant benefit. Worked as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Release v0.7.0.beta.1
Related Github Issue
https://github.com/GSA/px-benefit-finder/milestone/13
Application Improvements
beforeunload event not handling full data object #1816
Content Improvements
Stray HTML on "Explore other potential benefits" page #1814
Add display order field in life event #1795
Data Improvements
Form-page-2 page change event firing twice #1786
a11y Improvements
a11y - Modal Zoom Scaling #1585
Custom Module Improvements
Add display order field in life event #1795
Make link field of relevant benefits of life event form required #1769
Detailed Testing steps
Application Improvements
beforeunload event not handling full data object #1816
Content Improvements
Stray HTML on "Explore other potential benefits" page #1814
</p>
tag is not rendered in stringreported:
expected:
Data Improvements
Form-page-2 page change event firing twice #1786
disability
bf_page_change
event for modal and form page 2 only fire onceexpected:
a11y Improvements
a11y - Modal Zoom Scaling #1585
/benefit-finder/death
-> modal view stepexpected
expected
Custom Module Improvements
Add display order field in life event #1795
admin/content?combine=&type=bears_life_event&status=All&langcode=All
Make link field of relevant benefits of life event form required #1769
admin/content?combine=&type=bears_life_event_form&status=All&langcode=All