Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1891 adjust modal margins #1920

Merged
merged 2 commits into from
Nov 5, 2024
Merged

1891 adjust modal margins #1920

merged 2 commits into from
Nov 5, 2024

Conversation

scottqueen-bixal
Copy link
Collaborator

PR Summary

this adjust the modal to correct for screen zoom percentages

Related Github Issue

Detailed Testing steps

  • pull changes locally
  • cd benefit-finder
  • npm install
  • npm run start
  • navigate to modal
  • zoom window to '500%'
  • zoom window to '40%'
  • ensure content remains centered

expected:

Screen.Recording.2024-11-05.at.9.53.29.AM.mov

@scottqueen-bixal scottqueen-bixal self-assigned this Nov 5, 2024
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review November 5, 2024 15:55
@scottqueen-bixal scottqueen-bixal merged commit cec87c6 into dev Nov 5, 2024
6 checks passed
@scottqueen-bixal scottqueen-bixal deleted the 1891-adjust-modal-margins branch November 5, 2024 15:55
@scottqueen-bixal scottqueen-bixal mentioned this pull request Nov 12, 2024
Closed
@scottqueen-bixal scottqueen-bixal added this to the v0.8.0.beta.1 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nehemiah-abuga nehemiah-abuga nehemiah-abuga approved these changes

Assignees

@scottqueen-bixal scottqueen-bixal

Labels
None yet
Projects
None yet
Milestone
v0.8.0.beta.1
Development

Successfully merging this pull request may close these issues.

Centering select an option modal text & buttons
2 participants
@scottqueen-bixal @nehemiah-abuga