-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.5.0.beta.1 #1597
Merged
Merged
Release v0.5.0.beta.1 #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g to, and include url with thrown errors
1453 content translations zero ben
1514 update result view value
1516 update benefit event values
….com:GSA/px-benefit-finder into 1516-new-event-open-all-accordions
1392 handle codes prod link test
new gtm event to track open all interactions on results view
…form delete if used
…ithub.com:GSA/px-benefit-finder into 1525-clean-benefit-finder-configuration
…files under custom/module location before copy over new updates
…tion 1525 clean benefit finder configuration
…-if-used 1521 disable life event form delete if still used
1564 content update zero benefits header
Benefit Finder Release v0.5.0.beta.1 (Sprint 36)
…px-benefit-finder into 1548-update-gtm-e2e-tests
1535 change section heading rem
1590 git hooks bugs
…px-benefit-finder into 1548-update-gtm-e2e-tests
1548 update gtm e2e tests
Benefit Finder Release v0.5.0 (Sprint 36) QA & Automated tests
scottqueen-bixal
requested review from
nehemiah-abuga,
XavierMetichecchia and
gchi25
July 24, 2024 13:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
https://github.com/GSA/px-benefit-finder/milestone/9?closed=1
Related Github Issue
Application Improvements
NEW FEATURE | Zero Benefits View (Baseline Functionality Only) #1367
When user clicks open all accordions and navigates to another page, the accordions are already open on the new page #1554
a11y Improvements
a11y | Fonts are not scaling on magnification #1452
Data Improvements
Structure Data Layer Values #1482
Create a unique data layer value for the modal #1478
bf_page_change fires multiple times on inital page load #1468
Update pageView data layer variable to differentiate between form pages #1477
Update accordion open data layer event names #1516
Create data layer push event for open all/close all accordion button on results pages #1515
Update pageView Data Layer variable #1514
Create data layer event to track benefit link click #1467
Add data layer value to track benefit accordion open #1466
Consolidate bf_count data layer event with bf_page_change #1538
Change modal_open event to a page_change event #1537
Remove viewState data layer variable #1536
Custom Module Improvements
Cannot delete life event form if still used #1521
Clean benefit finder configuration #1525
Disable json file generation in BF multi-content action #1338
Remove deprecated function node_revision_load #1541
Detailed Testing steps
Application Improvements
NEW FEATURE | Zero Benefits View (Baseline Functionality Only) #1367
User Story
As a user, that does not meet any of the eligibility criteria for all benefits, I should be notified that I have no eligible results and be given the option to see all benefits.
/death
NO
( this ensures no benefits view)expected:
See all benefits
expected:
YES
( this ensures eligible benefits view)expected:
BUGFIX: When user clicks open all accordions and navigates to another page, the accordions are already open on the new page #1554
How to replicate
/death
YES
values to radiosopen all +
accordionsexpected:
https://github.com/user-attachments/assets/3f110b55-5cab-41fe-956d-ecf02f39ebae
expected:
https://github.com/user-attachments/assets/4a60367a-c893-40b0-ba8c-9784d5b01358
a11y Improvements
BUGFIX: a11y | Fonts are not scaling on magnification #1452
What happened
Beta release has fixed font sizes using an absolute length unit, px
How to replicate
/death
expected:
expected:
rem
expected:
Data Improvements
BUGFIX: bf_page_change fires multiple times on inital page load #1468
What happened
bf_page_change is fired twice, likely due to reacts caching lifecycle
How to replicate
/death
bf_page_change
eventsbf_page_change
eventexpected:
Structure Data Layer Values #1482
Create a unique data layer value for the modal #1478
Update pageView data layer variable to differentiate between form pages #1477
Update accordion open data layer event names #1516
Create data layer push event for open all/close all accordion button on results pages #1515
Update pageView Data Layer variable #1514
Create data layer event to track benefit link click #1467
Add data layer value to track benefit accordion open #1466
Consolidate bf_count data layer event with bf_page_change #1538
Change modal_open event to a page_change event #1537
Remove viewState data layer variable #1536
User Journey:
/death
Start
Continue
Continue
Review selections
Continue
See all benefits
open all
close all
Custom Module Improvements
Cannot delete life event form if still used #1521
admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
Delete
Delete
confirmation buttonSave
Save
Now delete life event form "Benefit finder: death of a loved one" again
Clean benefit finder configuration #1525
admin/config/development/usagov_benefit_finder
Disable json file generation in BF multi-content action #1338
admin/content?combine=&type=bears_criteria&status=All&langcode=All
Remove deprecated function node_revision_load #1541
admin/content?combine=&type=bears_life_event_form&status=All&langcode=All