Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.5.0.beta.1 #1597

Merged
merged 369 commits into from
Jul 24, 2024
Merged

Release v0.5.0.beta.1 #1597

merged 369 commits into from
Jul 24, 2024

Conversation

scottqueen-bixal
Copy link
Collaborator

@scottqueen-bixal scottqueen-bixal commented Jul 23, 2024

PR Summary

https://github.com/GSA/px-benefit-finder/milestone/9?closed=1

Related Github Issue

Application Improvements

NEW FEATURE | Zero Benefits View (Baseline Functionality Only) #1367
When user clicks open all accordions and navigates to another page, the accordions are already open on the new page #1554

a11y Improvements

a11y | Fonts are not scaling on magnification #1452

Data Improvements

Structure Data Layer Values #1482
Create a unique data layer value for the modal #1478
bf_page_change fires multiple times on inital page load #1468
Update pageView data layer variable to differentiate between form pages #1477
Update accordion open data layer event names #1516
Create data layer push event for open all/close all accordion button on results pages #1515
Update pageView Data Layer variable #1514
Create data layer event to track benefit link click #1467
Add data layer value to track benefit accordion open #1466
Consolidate bf_count data layer event with bf_page_change #1538
Change modal_open event to a page_change event #1537
Remove viewState data layer variable #1536

Custom Module Improvements

Cannot delete life event form if still used #1521
Clean benefit finder configuration #1525
Disable json file generation in BF multi-content action #1338
Remove deprecated function node_revision_load #1541

Detailed Testing steps

Application Improvements

NEW FEATURE | Zero Benefits View (Baseline Functionality Only) #1367

User Story

As a user, that does not meet any of the eligibility criteria for all benefits, I should be notified that I have no eligible results and be given the option to see all benefits.

  • navigate to /death
  • apply values to all required fields
  • for all radio inputs, select NO ( this ensures no benefits view)

expected:
Screenshot 2024-07-24 at 8 12 57 AM

  • click See all benefits

expected:
Screenshot 2024-07-24 at 8 13 12 AM

  • return back to start of form, for all radio inputs, select YES ( this ensures eligible benefits view)

expected:
Screenshot 2024-06-24 at 5 56 03 PM

BUGFIX: When user clicks open all accordions and navigates to another page, the accordions are already open on the new page #1554

How to replicate

  • On production,
  • navigate to /death
  • apply values to all required fields, providing YES values to radios
  • On the results view, open all + accordions
  • Click to "Benefits you didn't qualify for",
  • confirm that the accordions will already be open when the view updates

expected:
https://github.com/user-attachments/assets/3f110b55-5cab-41fe-956d-ecf02f39ebae

  • Repeat process with latest code
  • confirm that the accordions are closed when the view updates

expected:
https://github.com/user-attachments/assets/4a60367a-c893-40b0-ba8c-9784d5b01358

a11y Improvements

BUGFIX: a11y | Fonts are not scaling on magnification #1452

What happened

Beta release has fixed font sizes using an absolute length unit, px

How to replicate

  • Chrome: Open Settings or Preferences and change the font size to Very large
  • navigate to /death

expected:
Screenshot 2024-07-24 at 8 43 52 AM

  • Repeat process with latest code
  • confirm that the heading font scales

expected:
Screenshot 2024-07-24 at 8 44 03 AM

  • inspect element
  • confirm headings are in rem

expected:
Screenshot 2024-07-24 at 8 41 52 AM

Data Improvements

BUGFIX: bf_page_change fires multiple times on inital page load #1468

What happened

bf_page_change is fired twice, likely due to reacts caching lifecycle

How to replicate

  • on production
  • navigate to /death
  • console.log(window.dataLayer)
  • note the two bf_page_change events
[
   ...
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-intro",
            "viewTitle": "Benefit finder: death of a loved one"
        }
    },
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-intro",
            "viewTitle": "Benefit finder: death of a loved one"
        }
    }
]
  • repeat steps with latest code
  • console.log(window.dataLayer)
  • note the single bf_page_change event

expected:

[
   ...
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-intro",
            "viewTitle": "Benefit finder: death of a loved one"
        }
    }
]

There are many changes to the dataLayer, we will roll these up into a single scenario test.

Structure Data Layer Values #1482
Create a unique data layer value for the modal #1478
Update pageView data layer variable to differentiate between form pages #1477
Update accordion open data layer event names #1516
Create data layer push event for open all/close all accordion button on results pages #1515
Update pageView Data Layer variable #1514
Create data layer event to track benefit link click #1467
Add data layer value to track benefit accordion open #1466
Consolidate bf_count data layer event with bf_page_change #1538
Change modal_open event to a page_change event #1537
Remove viewState data layer variable #1536

User Journey:

  • navigate to /death
  • CLICK Start
  • fill out required fields on step 1
  • CLICK Continue
  • fill out required fields on step 2
  • CLICK Continue
  • CLICK Review selections
  • CLICK Continue
  • CLICK See all benefits
  • CLICK open all
  • CLICK close all
  • CLICK a benefit accordion to open
  • CLICK the open benefit button to open new window
  • console.log(window.dataLayer)
  • confirm your data array is similar in structure to what you see below (** note: some values are dynamic and can update based on current state of content)
[
    {
        "nodeID": "1978",
        "contentType": "bears_life_event",
        "language": "en",
        "homepageTest": "not_homepage",
        "basicPagesubType": null,
        "Page_Type": "bears_life_event",
        "Taxonomy_Text_1": "Home",
        "Taxonomy_Text_2": "Government benefits",
        "Taxonomy_Text_3": "Benefit finder",
        "Taxonomy_Text_4": "Death of a loved one",
        "Taxonomy_Text_5": "Death of a loved one",
        "Taxonomy_Text_6": "Death of a loved one",
        "Taxonomy_URL_1": "/",
        "Taxonomy_URL_2": "/benefits",
        "Taxonomy_URL_3": "/benefit-finder",
        "Taxonomy_URL_4": "/benefit-finder/death",
        "Taxonomy_URL_5": "/benefit-finder/death",
        "Taxonomy_URL_6": "/benefit-finder/death"
    },
    {
        "gtm.start": 1721826020368,
        "event": "gtm.js"
    },
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-intro",
            "viewTitle": "Benefit finder: death of a loved one"
        }
    },
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-form-1",
            "viewTitle": "About the applicant"
        }
    },
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-form-2",
            "viewTitle": "About the deceased"
        }
    },
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-form-completion-modal",
            "viewTitle": "About the deceased modal"
        }
    },
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-verify-selections",
            "viewTitle": "Review and confirm"
        }
    },
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-result-eligible-view",
            "viewTitle": "You are likely not eligible for these benefits.",
            "eligibleBenefitCount": {
                "number": 0,
                "string": "0"
            },
            "moreInfoBenefitCount": {
                "number": 16,
                "string": "16"
            },
            "notEligibleBenefitCount": {
                "number": 14,
                "string": "14"
            }
        }
    },
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-result-not-eligible-view",
            "viewTitle": "Benefits you did not qualify for",
            "eligibleBenefitCount": {
                "number": 0,
                "string": "0"
            },
            "moreInfoBenefitCount": {
                "number": 16,
                "string": "16"
            },
            "notEligibleBenefitCount": {
                "number": 14,
                "string": "14"
            }
        }
    },
    {
        "event": "bf_open_all_accordions",
        "bfData": {
            "accordionsOpen": true
        }
    },
    {
        "event": "bf_open_all_accordions",
        "bfData": {
            "accordionsOpen": false
        }
    },
    {
        "event": "bf_accordion_open",
        "bfData": {
            "benefitTitle": "COVID-19 funeral assistance"
        }
    },
    {
        "event": "bf_benefit_link",
        "bfData": {
            "benefitTitle": "COVID-19 funeral assistance"
        }
    }
]

Custom Module Improvements

Cannot delete life event form if still used #1521

  • Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
  • Go to life event form "Benefit finder: death of a loved one" edit page
  • Click Delete
  • Verify the warning message "cannot delete the life event form" and list of life event forms
  • verify that no Delete confirmation button

image

  • Go to life event form "Benefit finder: retirement" edit page
  • Remove life event form "Benefit finder: death of a loved one" in relevant benefit
  • Click Save
  • Go to life event form "Benefit finder: disability" edit page
  • Remove life event form "Benefit finder: death of a loved one" in relevant benefit
  • Click Save

Now delete life event form "Benefit finder: death of a loved one" again

  • Go to life event form "Benefit finder: death of a loved one" edit page
  • Click Delete
  • Verify message "This action cannot be undone"
  • Verify message "The following entity references will be skipped and leave orphans" and list of benefits
  • Click Delete button to delete this life event form
  • Verify life event form "Benefit finder: death of a loved one" deleted

Clean benefit finder configuration #1525

  • Go to life event "Benefit finder: death of a loved one" edit page
  • Verify field ID is required
  • Verify field Page intro
  • Verify field Meta Description
  • Verify field Short Description
  • Verify field Search Title
  • Go to criteria "Deceased served in active military" edit page
  • Verify field ID is required
  • Verify check field has Child to show field Child Dependency Option
  • Verify uncheck field has Child to hide field Child Dependency Option
  • Go to benefit "COVID-19 funeral assistance" edit page
  • Verify no life event field
  • Go to life event form "Benefit finder: death of a loved one" edit page
  • Verify field life event form is required field in field relevant benefit
  • Navigate to admin/config/development/usagov_benefit_finder
  • Verify Automate JSON file generation checked

Disable json file generation in BF multi-content action #1338

  • navigate to admin/content?combine=&type=bears_criteria&status=All&langcode=All
  • select several criteria
  • select "Publish content" in action list
  • click "Apply to selected items" button
  • verify that the system not generating json files
  • verify that the system displays warning message

Remove deprecated function node_revision_load #1541

  • Make local development site up at http://localhost
  • Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
  • Go to life event form "Benefit finder: death of a loved one" edit page
  • Changed Time Estimate from 5-10 minutes to 10-20 minutes
  • Save as published to generate both draft and published JSON files
  • Navigate to benefit finder tool draft mode benefit-finder/death?mode=draft
  • Verify estimated time 10-20 minutes
  • Navigate to benefit finder tool published mode benefit-finder/death
  • Verify estimated time 10-20 minutes

scottqueen-bixal and others added 30 commits July 1, 2024 18:17
….com:GSA/px-benefit-finder into 1516-new-event-open-all-accordions
new gtm event to track open all interactions on results view
…ithub.com:GSA/px-benefit-finder into 1525-clean-benefit-finder-configuration
…files under custom/module location before copy over new updates
…tion

1525 clean benefit finder configuration
…-if-used

1521 disable life event form delete if still used
scottqueen-bixal and others added 22 commits July 23, 2024 11:47
1564 content update zero benefits header
Benefit Finder Release v0.5.0.beta.1 (Sprint 36)
Benefit Finder Release v0.5.0 (Sprint 36) QA & Automated tests
@scottqueen-bixal scottqueen-bixal changed the title Main Release v0.5.0.beta.1 Jul 24, 2024
@scottqueen-bixal scottqueen-bixal added this to the v0.5.0.beta.1 milestone Jul 24, 2024
@scottqueen-bixal scottqueen-bixal self-assigned this Jul 24, 2024
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review July 24, 2024 13:12
@github-actions github-actions bot merged commit 607eb13 into release Jul 24, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants