Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1564 content update zero benefits header #1594

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

scottqueen-bixal
Copy link
Collaborator

@scottqueen-bixal scottqueen-bixal commented Jul 23, 2024

PR Summary

Related Github Issue

Detailed Testing steps

  • pull changes locally
  • cd benefit-finder
  • npm install
  • npm run start
  • navigate to /death
  • complete form, only providing values to required fields
  • ensure zero benefits view
  • Click See all benefits button

In English

On the All non-eligible benefits page:

  • ensure H1 has changed from "You are likely not eligible for these benefits" --> "Benefits you did not qualify for"

  • ensure H2 has changed from "If you reached these results by mistake, please go back to review your answers" --> "According to your answers you are not eligible for these benefits."

  • toggle spanish view

In Spanish

  • ensure the period in the H1 "Usted parece no ser eligible para estos beneficios." --> "Usted parece no ser eligible para estos beneficios"
  • Click Ver todos los resultados button

On the All non-eligible benefits page:

  • ensure H1 has changed from "Usted parece no ser eligible para estos beneficios." --> "Beneficios a los que no calificó"
  • ensure H2 has changed from "Si cree que cometió un error, por favor regrese para corregir sus respuestas." --> "Según sus respuestas usted no es elegible para estos beneficios."

@scottqueen-bixal scottqueen-bixal self-assigned this Jul 23, 2024
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review July 23, 2024 15:53
Copy link
Collaborator

@nehemiah-abuga nehemiah-abuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified this changes. Looking good

@scottqueen-bixal scottqueen-bixal merged commit 6e60721 into dev Jul 23, 2024
7 of 8 checks passed
@scottqueen-bixal scottqueen-bixal deleted the 1564-content-update-zeroben branch July 23, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not Eligible Benefits header in Zero Benefits Results Page
2 participants