Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1535 change section heading rem #1586

Merged
merged 37 commits into from
Jul 23, 2024
Merged

Conversation

scottqueen-bixal
Copy link
Collaborator

@scottqueen-bixal scottqueen-bixal commented Jul 22, 2024

PR Summary

Related Github Issue

Detailed Testing steps

  • pull changes locally
  • cd benefit-finder
  • npm install
  • npm run start
  • visit /death
  • expect bf-section-heading to be 2.25rem or 36px
  • expect bf-usa-section-heading to be 2rem or 32px

expected view:
"Answer these questions" Heading use Public Sans Extra Bold 36pt.
"About the applicant" Subheading use Public Sans Bold 32pt
Screenshot 2024-07-16 at 10 38 28 AM

@scottqueen-bixal scottqueen-bixal self-assigned this Jul 22, 2024
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review July 22, 2024 19:44
Copy link
Collaborator

@nehemiah-abuga nehemiah-abuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified these changes.
image

image

@scottqueen-bixal scottqueen-bixal merged commit e87a3a0 into dev Jul 23, 2024
7 of 8 checks passed
@scottqueen-bixal scottqueen-bixal deleted the 1535-change-section-heading-rem branch July 23, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Section heading as h1 not scaled appropriately
2 participants