Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spreadsheet fixes #181

Merged
merged 24 commits into from
Aug 15, 2023
Merged

Spreadsheet fixes #181

merged 24 commits into from
Aug 15, 2023

Conversation

duncandewhurst
Copy link
Contributor

@duncandewhurst duncandewhurst commented Aug 8, 2023

Related issues

Description

This PR fixes some issues I noticed whilst working on the spreadsheet template:

  • Fix codelist filename in Classification.scheme
  • Fix {{version}} placeholder replacement in schema
  • Make version of type string, per the field description
  • Fix required fields in Event_set, Hazard and Footprint
  • Fix markdown syntax in Attribution.role description

It also moves the codelists folder inside the schema folder so that the codelist CSV files can be copied to the built version of the documentation. That way, the CSV files can be accessed by the script that generates the spreadsheet template and any other tools that might need them, e.g. CoVE.

Merge checklist

  • Update the changelog (style guide)
  • Run ./manage.py pre-commit

If you added or removed a field:

  • Update the collapse option of the jsonschema directives for dataset, resource, hazard, exposure, vulnerability and loss on reference/schema.md

Having trouble?

See how to resolve check failures.

@duncandewhurst duncandewhurst marked this pull request as ready for review August 10, 2023 23:57
@duncandewhurst duncandewhurst requested a review from odscjen August 10, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants