Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataset id path should be identifier as per the schema #7

Closed
odscjen opened this issue Aug 10, 2023 · 1 comment
Closed

dataset id path should be identifier as per the schema #7

odscjen opened this issue Aug 10, 2023 · 1 comment
Assignees
Labels
invalid This doesn't seem right

Comments

@odscjen
Copy link
Collaborator

odscjen commented Aug 10, 2023

Currently in the spreadsheet on sheet datasets cell B1 is id but it should be identifier

@odscjen odscjen added the invalid This doesn't seem right label Aug 10, 2023
@duncandewhurst
Copy link
Collaborator

I've changed identifier to id in the schema in GFDRR/rdl-standard#181 because Flatten Tool requires identifiers to have consistent field names and we've used id everywhere but the top-level object. Therefore, there's no change required to the spreadsheet template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants