-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Schema] Hazard object (i.e. hazard type and process) required in both event_set and event? #188
Comments
These issues are addressed in #181. However, you're right that we do need to decide what to do about making Personally, I favour fewer required fields to avoid creating unintended barriers to publication. Therefore, I would remove make |
From today's check-in call with @matamadio and @odscrachel, we agreed that We'll need to check and update the required fields and descriptions in the schema. Also noting the need to clearly explain the relationship between event sets and events in the documentation, which should be addressed by #178 |
this has now been dealt with in #181 and reviewing the descriptions they all seem to cover what was agreed so I'm closing this |
EDIT: a number of these where already being addressed in another PR #181
Noting a number of necessary minor schema changes that testing of the spreadsheet conversion has brought up.* changeversion
type from "number" to "string"event_set.hazard_type
is down as required, but it's not actually a field withinevent_set
rather its a field withinHazard
which is referenced inevent_set.hazards
.event.hazard
is also down as required andevents
is required inevent_set
. We needed this info at bothevent_set
andevent
level (as discussed in #91) but by having both as required it does mean we're asking people to duplicate info in multiple places in situations where the hazard type and process and intensity measure are the same for every event in the event_set. But maybe that's a price we have to pay to ensure it's included in at least one place? @matamadio @stufraser1 @duncandewhurst thoughts?*Hazard
hasprocess
as required but the field is actuallyprocesses
The text was updated successfully, but these errors were encountered: