chore: remove method that's same as base method #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedsalk
commented
Nov 22, 2023
nedsalk
requested review from
digorithm,
arboleya,
camsjams,
Torres-ssf,
Dhaiwat10 and
danielbate
as code owners
Coverage report
Test suite run success1477 tests passing in 259 suites. Report generated by 🧪jest coverage report action from 54277ae |
camsjams
reviewed
Nov 25, 2023
There was a problem hiding this comment.
Seems fine since the tests pass, but how is the function scope still working as it does when used on the Script version?
This was part of the refactor to a new file long ago in #745 and at the time these callsites matched.
It does look safer to remove the copy, as they have since branched with slightly different implementation details.
…-call-method-on-ScriptInvocationScope
arboleya
reviewed
Dec 12, 2023
…ScriptInvocationScope
|
Moved base from |
nedsalk
changed the title
…ScriptInvocationScope
arboleya
approved these changes
Dec 13, 2023
…ScriptInvocationScope
Torres-ssf
approved these changes
Dec 14, 2023
…ScriptInvocationScope
nedsalk
deleted the
ns/refactor/-remove-call-method-on-ScriptInvocationScope
branch
arboleya
added a commit
that referenced
this pull request
Jan 26, 2024
* chore: updating code owners (#1496) * docs: purge hardcoded snippets on 'using typegen' page (#1403) * chore: remove method that's same as base method (#1445) * chore: implement RC workflow (#1497) * Revert "feat: add `Predicate.getTransferTxId` helper (#1467)" * chore: fix rc release string replace (#1529) * docs: Update some hyperlinks to reference the new documentation hub (#1520) * chore: improve rc release message (#1559) * feat: GraphQL subscriptions (#1374) * chore: pin `graphql-request` to `v5` (#1567) * chore: upgrade `tsx` (#1574) * feat: migrate from Jest to Vitest (#1310) * chore: fix temp test workflow (#1579) * chore: update required node engine in `create-fuels` (#1582) * chore: add node version test matrix (#1575) * chore: fix broken rc message (#1580) * chore: update nodejs to v20 (#1544) * feat: accepting addresses as `string` (#1583) * chore: properly format the PR coverage report comment (#1586) * fix: flaky test (#1590) * docs: update `deposit-and-withdraw` page (#1591) * feat: retry mechanism (#1474) * feat: replaced `semver` dependency with custom implementation (#1594) * feat: replace `elliptic` with `@noble/curves` (#1601) * chore: fix CI failing due to missing tag in test (#1614) * feat: improve ABI Coders `decode` validation (#1426) * fix: do not generate a coverage diff without coverage artifact (#1629) * chore: pinpoint vitest to 1.0.4 (#1637) * chore: remove `ethers` dependency from `utils` (#1640) * fix: `getOperation` for `Transfer Asset` (#1619) * fix: remove external font dependencies (#1642) * fix: generate RC PR comment on `pull_request` event only (#1648) * fix: fix failing `rc` comment (#1657) * chore: add missing test group (#1658) * feat: implement browser compatibility testing (#1630) * chore: fix string replace in `rc` ci (#1659) * chore: adding extra reporters (#1661) * chore: manually trigger `rc` CI (#1660) * feat: use `submitAndAwait` graphql endpoint (#1615) * fix: flaky retry test (#1654) * feat: create a wallet without a provider (#1566) * chore!: Share single chainConfig and review node-related utilities (#1602) * chore: use new temporary coverage artifact (#1676) * fix: internalizing `findBinPath` utility (#1679)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you take a look at
BaseInvocationScope.call, you'll see that it's essentially the same implementation as this removed method that was overriding it.