-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add main arg support to Scripts #745
Conversation
Coverage report
Show new covered files 🐣
Test suite run success728 tests passing in 99 suites. Report generated by 🧪jest coverage report action from 28c6871 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arboleya yea I think I'd like to refactor this PR a little bit to make it more like Contract DX I'm going to mark as a draft |
@arboleya I reworked this to make Scripts usage available as a method of a Wallet. This is similar to how Predicates work as generally using a script will always require funds to complete, so its a function of having available assets to spend in the transaction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff -- looks pretty clean to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of the program
package couldn't feel more appropriate. 😌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant!
closes #698
Follow-up in here for additional testing: #757