Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin graphql-request to v5 #1567

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

danielbate
Copy link
Member

There is an issue in v5.2 of graphql-request that breaks builds of the providers package by including a TS error in the code-generated operations.ts file.

We don't have much flex on this file unless we add hooks to find/replace the issues, which doesn't appeal to me as a good fix. Until a better fix has been released, we should pin to v5.

Found this on a failing build in #1310, however I'd like to release it in isolation.

@danielbate danielbate added the chore Issue is a chore label Dec 19, 2023
@danielbate danielbate added this to the 1 - Salamander milestone Dec 19, 2023
@danielbate danielbate self-assigned this Dec 19, 2023
Copy link
Contributor

github-actions bot commented Dec 19, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
87.36% (+0.48% 🔼)
6128/7015
🟡 Branches
71.42% (+0.56% 🔼)
957/1340
🟡 Functions
79.15% (+1.37% 🔼)
1010/1276
🟢 Lines
87.19% (+0.33% 🔼)
5880/6744
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / fuel-graphql-subscriber.ts
82.61% 60% 100% 82.61%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / transaction-request.ts
75.68% (+0.68% 🔼)
63.27% (+2.04% 🔼)
70.83% (-1.51% 🔻)
75.71% (+0.71% 🔼)

Test suite run success

1483 tests passing in 259 suites.

Report generated by 🧪jest coverage report action from 58b8037

@danielbate danielbate enabled auto-merge (squash) December 20, 2023 11:07
@danielbate danielbate merged commit 58ef6e7 into rc/salamander Dec 20, 2023
9 checks passed
@danielbate danielbate deleted the db/chore/pin-gql-request-version branch December 20, 2023 11:17
@arboleya arboleya mentioned this pull request Jan 26, 2024
44 tasks
arboleya added a commit that referenced this pull request Jan 26, 2024
* chore: updating code owners (#1496)
* docs: purge hardcoded snippets on 'using typegen' page (#1403)
* chore: remove method that's same as base method (#1445)
* chore: implement RC workflow (#1497)
* Revert "feat: add `Predicate.getTransferTxId` helper (#1467)"
* chore: fix rc release string replace (#1529)
* docs: Update some hyperlinks to reference the new documentation hub (#1520)
* chore: improve rc release message (#1559)
* feat: GraphQL subscriptions (#1374)
* chore: pin `graphql-request` to `v5` (#1567)
* chore: upgrade `tsx` (#1574)
* feat: migrate from Jest to Vitest (#1310)
* chore: fix temp test workflow (#1579)
* chore: update required node engine in `create-fuels` (#1582)
* chore: add node version test matrix (#1575)
* chore: fix broken rc message (#1580)
* chore: update nodejs to v20 (#1544)
* feat: accepting addresses as `string` (#1583)
* chore: properly format the PR coverage report comment (#1586)
* fix: flaky test (#1590)
* docs: update `deposit-and-withdraw` page (#1591)
* feat: retry mechanism (#1474)
* feat: replaced `semver` dependency with custom implementation (#1594)
* feat: replace `elliptic` with `@noble/curves` (#1601)
* chore: fix CI failing due to missing tag in test (#1614)
* feat: improve ABI Coders `decode` validation (#1426)
* fix: do not generate a coverage diff without coverage artifact (#1629)
* chore: pinpoint vitest to 1.0.4 (#1637)
* chore: remove `ethers` dependency from `utils` (#1640)
* fix: `getOperation` for `Transfer Asset` (#1619)
* fix: remove external font dependencies (#1642)
* fix: generate RC PR comment on `pull_request` event only (#1648)
* fix: fix failing `rc` comment (#1657)
* chore: add missing test group (#1658)
* feat: implement browser compatibility testing (#1630)
* chore: fix string replace in `rc` ci (#1659)
* chore: adding extra reporters (#1661)
* chore: manually trigger `rc` CI (#1660)
* feat: use `submitAndAwait` graphql endpoint (#1615)
* fix: flaky retry test (#1654)
* feat: create a wallet without a provider (#1566)
* chore!: Share single chainConfig and review node-related utilities (#1602)
* chore: use new temporary coverage artifact (#1676)
* fix: internalizing `findBinPath` utility (#1679)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants