Choose default RID based on the build platform #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only applied for "Debug" configuration. Release will/should require the target RID(s) to be specified.
|
Should we set a condition on the RuntimeIdentifiers element to execute only if the configuration is Release? |
|
Ooh ooh! Just talking to @codingbandit who is tinkering around this space, and for DEBUG we might be able to embed "dotnet (pluginName)" in the manifest. For RELEASE, replace with the correct executable names. |
benaadams
reviewed
Jan 27, 2019
Only include the `RuntimeSpecifiers` (plural) when building in `Release` configuration. Co-Authored-By: hugodahl <[email protected]>
|
All in all, who would've thought, starting out on Friday morning, that such a seeming small detail would cause such a flurry of activity and discussions! |
Oh wow, that's awesome! Everyone should be so fortunate as to know someone as smart and resourceful as @codingbandit in their domain. |
|
Thank you @hugodahl @benaadams for this, it will make it easier to build on BOTH Windows and Mac |
csharpfritz
added a commit
that referenced
this pull request
Jan 29, 2019
* Fixing dev (#43) * Implemented the rest of the events the StreamDeck App can send our plugin * Revert "Implement StreamDeck Events Received" * almost finished with mac script * finalized mac inner loop * Added vscode workspace stub to build upon (#41) * now it will compile (#44) * started working on fixing the dotnet new experience for mac * fixed compilation * added debug capability, not quite there yet * register plugin tidy up - Added liberal comments - Removed jq, it is great, but not on a system with a standard installation. The sed solution #workedonmymachine - Added #shebang * update .ignore ignore platform specific files. * standardize Bash language features surround variables with {} pull constants to top of script notify user script is finished. * got the inner loop better * added win10 directory to bindir in powershell, re-added the win10 runtime indentifier in csproj (#55) * Readme (#52) * Basic Usage defined in README - Outline of template installation - Brief overview of new’upping a project. * typo found. * Corrected capitalization of NuGet * Basic project stub setup for unit tests (#46) * Added vscode workspace stub to build upon * Test project setup and intial test to check things work * #15: Added code coverage support * #15: Encapsulated overload of Initialize not called outside StreamDeckLib * #15: Made BaseStreamDeckPlugin abstract to reduce test scenario count * Update README.md Updated links on badges * Updated layout of the badges + click-through * Added Intellicode Model * Added tests badge * Choose default RID based on the build platform (#57) * Choose default RID based on the build platform Only applied for "Debug" configuration. Release will/should require the target RID(s) to be specified. * Update src/SamplePlugin/SamplePlugin.csproj Only include the `RuntimeSpecifiers` (plural) when building in `Release` configuration. Co-Authored-By: hugodahl <[email protected]> * Refactored to an Proxy interface to address #47 (#58) * Add license file for the project (#60) * Add license file (MIT) The license is referenced in the .nuspec file for the template, but did not exist in the repository. The source of the text is https://opensource.org/licenses/MIT, for which I've set the year of copyright only (not the holder). * Change the name of the copyright holder to Jeff for now * Add information and pre-requisite info (Issue #62) (#63) * Add some information about pre-requisites for the template * Fix details and grammar * Added remaining Events Sent to ConfigurationManager (#64) * Refactored to an Proxy interface to address #47 * Added remaining EventsSent to ConfigurationManager * OS X Workflow Updates (#59) * updating editor config to use lf end of line for bash scripts * updated Register Plugin bash script to correctly deploy plugin * corrected the CodePathMac setting in the manifest.json to point at the executable * adding a pre run validation of the jq dependency * removed the use of jq using sed instead * Update LICENSE (#65) Update the contents and layout of the [`LICENSE`](https://github.com/FritzAndFriends/StreamDeckEmulator/blob/master/LICENSE) file from the [FritzAndFriends/StreamDeckEmulator](https://github.com/FritzAndFriends/StreamDeckEmulator/) repository for readability and consistency. * Documentation/update template packaging contents (#66) * Update URL to repository and repository-based assets * Start of a 'What next' document after running the template * Add details about project files. Specify function for the main code files. Start image specification details. Plugin icon done. * Update README with sections outlines for additional icons * Finish first draft of 'What's next' for template consumer * Move images to separate image directory Do for both SamplePlugin and Template to maintain symmetry. * Update manifest with new path to images * Minor changes and edits to README Include a note about cross-platform paths
csharpfritz
added a commit
that referenced
this pull request
Jan 29, 2019
* Fixing dev (#43) * Implemented the rest of the events the StreamDeck App can send our plugin * Revert "Implement StreamDeck Events Received" * almost finished with mac script * finalized mac inner loop * Added vscode workspace stub to build upon (#41) * now it will compile (#44) * started working on fixing the dotnet new experience for mac * fixed compilation * added debug capability, not quite there yet * register plugin tidy up - Added liberal comments - Removed jq, it is great, but not on a system with a standard installation. The sed solution #workedonmymachine - Added #shebang * update .ignore ignore platform specific files. * standardize Bash language features surround variables with {} pull constants to top of script notify user script is finished. * got the inner loop better * added win10 directory to bindir in powershell, re-added the win10 runtime indentifier in csproj (#55) * Readme (#52) * Basic Usage defined in README - Outline of template installation - Brief overview of new’upping a project. * typo found. * Corrected capitalization of NuGet * Basic project stub setup for unit tests (#46) * Added vscode workspace stub to build upon * Test project setup and intial test to check things work * #15: Added code coverage support * #15: Encapsulated overload of Initialize not called outside StreamDeckLib * #15: Made BaseStreamDeckPlugin abstract to reduce test scenario count * Update README.md Updated links on badges * Updated layout of the badges + click-through * Added Intellicode Model * Added tests badge * Choose default RID based on the build platform (#57) * Choose default RID based on the build platform Only applied for "Debug" configuration. Release will/should require the target RID(s) to be specified. * Update src/SamplePlugin/SamplePlugin.csproj Only include the `RuntimeSpecifiers` (plural) when building in `Release` configuration. Co-Authored-By: hugodahl <[email protected]> * Refactored to an Proxy interface to address #47 (#58) * Add license file for the project (#60) * Add license file (MIT) The license is referenced in the .nuspec file for the template, but did not exist in the repository. The source of the text is https://opensource.org/licenses/MIT, for which I've set the year of copyright only (not the holder). * Change the name of the copyright holder to Jeff for now * Add information and pre-requisite info (Issue #62) (#63) * Add some information about pre-requisites for the template * Fix details and grammar * Added remaining Events Sent to ConfigurationManager (#64) * Refactored to an Proxy interface to address #47 * Added remaining EventsSent to ConfigurationManager * OS X Workflow Updates (#59) * updating editor config to use lf end of line for bash scripts * updated Register Plugin bash script to correctly deploy plugin * corrected the CodePathMac setting in the manifest.json to point at the executable * adding a pre run validation of the jq dependency * removed the use of jq using sed instead * Update LICENSE (#65) Update the contents and layout of the [`LICENSE`](https://github.com/FritzAndFriends/StreamDeckEmulator/blob/master/LICENSE) file from the [FritzAndFriends/StreamDeckEmulator](https://github.com/FritzAndFriends/StreamDeckEmulator/) repository for readability and consistency. * Documentation/update template packaging contents (#66) * Update URL to repository and repository-based assets * Start of a 'What next' document after running the template * Add details about project files. Specify function for the main code files. Start image specification details. Plugin icon done. * Update README with sections outlines for additional icons * Finish first draft of 'What's next' for template consumer * Move images to separate image directory Do for both SamplePlugin and Template to maintain symmetry. * Update manifest with new path to images * Minor changes and edits to README Include a note about cross-platform paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only applied for the
Debugconfiguration.Releasewill/should require the target RID(s) to be specified, unless we update the.csprojwith different rules.This addresses issue #56