-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests needed #15
Comments
We will create a /tests folder to hold the unit tests |
@csharpfritz do you have any preference for UnitTest framework? Mocking framework or DI for this? Do you want to keep it vanilla .net core or are you open to other options? |
I like xunit and Moq.
I don’t think a DI Framework is needed.
What other options do you have in mind?
Jeff
… On Jan 21, 2019, at 17:44, Simon Geering ***@***.***> wrote:
@csharpfritz do you have any preference for UnitTest framework? Mocking framework or DI for this? Do you want to keep it vanilla .net core or are you open to other options?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I didn't have anything specific in mind, rather I'm happy to go with whatever you feel like using just didn't know what you were thinking. I'll have a play and see where I get, though I'm happy if someone else wants to jump in on this ahead of me. |
I have managed to get an initial stab at a unit test project into the solution with XUnit, Moq and FluentAssertions but since it is now silly o'clock in the morning here in the UK, and my forked branch is behind FritzAndFriends, a PR will have to wait until tomorrow when I have time to pull changes integrate and re-test a build. |
@csharpfritz Any objections to an additional two references in the test project?
These combined will give us cross-platform support for code coverage statistics creation and reporting which will work from both VSCode and later be something we can hook into as part of the CI pipeline from the dotnet CLI |
Sounds fine to me
Jeff
… On Jan 22, 2019, at 15:47, Simon Geering ***@***.***> wrote:
@csharpfritz Any objections to an additional two references in the test project?
A PackageReference to the NuGet package https://www.nuget.org/packages/coverlet.msbuild/
A DotNetCliToolReference to https://www.nuget.org/packages/dotnet-reportgenerator-cli/
These combined will give us cross-platform support for code coverage statistics creation and reporting which will work from both VSCode and later be something we can hook into as part of the CI pipeline from the dotnet CLI
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
* Fixing dev (#43) * Implemented the rest of the events the StreamDeck App can send our plugin * Revert "Implement StreamDeck Events Received" * almost finished with mac script * finalized mac inner loop * Added vscode workspace stub to build upon (#41) * now it will compile (#44) * started working on fixing the dotnet new experience for mac * fixed compilation * added debug capability, not quite there yet * register plugin tidy up - Added liberal comments - Removed jq, it is great, but not on a system with a standard installation. The sed solution #workedonmymachine - Added #shebang * update .ignore ignore platform specific files. * standardize Bash language features surround variables with {} pull constants to top of script notify user script is finished. * got the inner loop better * added win10 directory to bindir in powershell, re-added the win10 runtime indentifier in csproj (#55) * Readme (#52) * Basic Usage defined in README - Outline of template installation - Brief overview of new’upping a project. * typo found. * Corrected capitalization of NuGet * Basic project stub setup for unit tests (#46) * Added vscode workspace stub to build upon * Test project setup and intial test to check things work * #15: Added code coverage support * #15: Encapsulated overload of Initialize not called outside StreamDeckLib * #15: Made BaseStreamDeckPlugin abstract to reduce test scenario count * Update README.md Updated links on badges * Updated layout of the badges + click-through * Added Intellicode Model * Added tests badge * Choose default RID based on the build platform (#57) * Choose default RID based on the build platform Only applied for "Debug" configuration. Release will/should require the target RID(s) to be specified. * Update src/SamplePlugin/SamplePlugin.csproj Only include the `RuntimeSpecifiers` (plural) when building in `Release` configuration. Co-Authored-By: hugodahl <[email protected]> * Refactored to an Proxy interface to address #47 (#58) * Add license file for the project (#60) * Add license file (MIT) The license is referenced in the .nuspec file for the template, but did not exist in the repository. The source of the text is https://opensource.org/licenses/MIT, for which I've set the year of copyright only (not the holder). * Change the name of the copyright holder to Jeff for now * Add information and pre-requisite info (Issue #62) (#63) * Add some information about pre-requisites for the template * Fix details and grammar * Added remaining Events Sent to ConfigurationManager (#64) * Refactored to an Proxy interface to address #47 * Added remaining EventsSent to ConfigurationManager * OS X Workflow Updates (#59) * updating editor config to use lf end of line for bash scripts * updated Register Plugin bash script to correctly deploy plugin * corrected the CodePathMac setting in the manifest.json to point at the executable * adding a pre run validation of the jq dependency * removed the use of jq using sed instead * Update LICENSE (#65) Update the contents and layout of the [`LICENSE`](https://github.com/FritzAndFriends/StreamDeckEmulator/blob/master/LICENSE) file from the [FritzAndFriends/StreamDeckEmulator](https://github.com/FritzAndFriends/StreamDeckEmulator/) repository for readability and consistency. * Documentation/update template packaging contents (#66) * Update URL to repository and repository-based assets * Start of a 'What next' document after running the template * Add details about project files. Specify function for the main code files. Start image specification details. Plugin icon done. * Update README with sections outlines for additional icons * Finish first draft of 'What's next' for template consumer * Move images to separate image directory Do for both SamplePlugin and Template to maintain symmetry. * Update manifest with new path to images * Minor changes and edits to README Include a note about cross-platform paths
* Fixing dev (#43) * Implemented the rest of the events the StreamDeck App can send our plugin * Revert "Implement StreamDeck Events Received" * almost finished with mac script * finalized mac inner loop * Added vscode workspace stub to build upon (#41) * now it will compile (#44) * started working on fixing the dotnet new experience for mac * fixed compilation * added debug capability, not quite there yet * register plugin tidy up - Added liberal comments - Removed jq, it is great, but not on a system with a standard installation. The sed solution #workedonmymachine - Added #shebang * update .ignore ignore platform specific files. * standardize Bash language features surround variables with {} pull constants to top of script notify user script is finished. * got the inner loop better * added win10 directory to bindir in powershell, re-added the win10 runtime indentifier in csproj (#55) * Readme (#52) * Basic Usage defined in README - Outline of template installation - Brief overview of new’upping a project. * typo found. * Corrected capitalization of NuGet * Basic project stub setup for unit tests (#46) * Added vscode workspace stub to build upon * Test project setup and intial test to check things work * #15: Added code coverage support * #15: Encapsulated overload of Initialize not called outside StreamDeckLib * #15: Made BaseStreamDeckPlugin abstract to reduce test scenario count * Update README.md Updated links on badges * Updated layout of the badges + click-through * Added Intellicode Model * Added tests badge * Choose default RID based on the build platform (#57) * Choose default RID based on the build platform Only applied for "Debug" configuration. Release will/should require the target RID(s) to be specified. * Update src/SamplePlugin/SamplePlugin.csproj Only include the `RuntimeSpecifiers` (plural) when building in `Release` configuration. Co-Authored-By: hugodahl <[email protected]> * Refactored to an Proxy interface to address #47 (#58) * Add license file for the project (#60) * Add license file (MIT) The license is referenced in the .nuspec file for the template, but did not exist in the repository. The source of the text is https://opensource.org/licenses/MIT, for which I've set the year of copyright only (not the holder). * Change the name of the copyright holder to Jeff for now * Add information and pre-requisite info (Issue #62) (#63) * Add some information about pre-requisites for the template * Fix details and grammar * Added remaining Events Sent to ConfigurationManager (#64) * Refactored to an Proxy interface to address #47 * Added remaining EventsSent to ConfigurationManager * OS X Workflow Updates (#59) * updating editor config to use lf end of line for bash scripts * updated Register Plugin bash script to correctly deploy plugin * corrected the CodePathMac setting in the manifest.json to point at the executable * adding a pre run validation of the jq dependency * removed the use of jq using sed instead * Update LICENSE (#65) Update the contents and layout of the [`LICENSE`](https://github.com/FritzAndFriends/StreamDeckEmulator/blob/master/LICENSE) file from the [FritzAndFriends/StreamDeckEmulator](https://github.com/FritzAndFriends/StreamDeckEmulator/) repository for readability and consistency. * Documentation/update template packaging contents (#66) * Update URL to repository and repository-based assets * Start of a 'What next' document after running the template * Add details about project files. Specify function for the main code files. Start image specification details. Plugin icon done. * Update README with sections outlines for additional icons * Finish first draft of 'What's next' for template consumer * Move images to separate image directory Do for both SamplePlugin and Template to maintain symmetry. * Update manifest with new path to images * Minor changes and edits to README Include a note about cross-platform paths
We need to start testing and ensuring the API continues to work properly
The text was updated successfully, but these errors were encountered: