-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHPStan and other quality checks #185
Conversation
Similar to FreshRSS core Contributes to #184
Only lacking a bit of work on:
Any takers please 🙏🏻? This PR can be also merged as-is after a bit of testing. |
I thought there was an issue (maybe by @math-GH ) somewhere about doing this PR, but I cannot find it at the moment... (Hints welcome) |
I've no time to test it, sorry. |
To accompany FreshRSS/Extensions#185
@Alkarex Probably not for a week, slightly depending on the weather. |
* Fix types for extensions To accompany FreshRSS/Extensions#185 * Avoid bug redeclared function
Sorry, I am late to the party. |
No, there is no possible path of update without also making a new FreshRSS release, so we need to issue 1.23.0 as soon as possible.
|
What lacks most urgently is testing the compatibility with older third-party extensions, which have not been updated. |
Related: FreshRSS/FreshRSS#5837 |
Partial follow-up of #185 (comment) Fix regression in typing for `getSrcSetUris`()
Partial follow-up of #185 (comment) Fix regression in typing for `getSrcSetUris`()
Similar to FreshRSS core
Contributes to #184
Uses FreshRSS/FreshRSS#5901
TODO: