Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recent commit (ce44911) breaks CustomCSS (possibly others) #184

Closed
edwrap opened this issue Nov 23, 2023 · 7 comments
Closed

Recent commit (ce44911) breaks CustomCSS (possibly others) #184

edwrap opened this issue Nov 23, 2023 · 7 comments
Labels
bug (confirmed)

Comments

@edwrap
Copy link

edwrap commented Nov 23, 2023

Commit: ce44911

Reposting my comment from the commit for added visibility:
The CustomCSS extension is broken after this commit (possibly others, too, but this is the only one I use). On a new install of FreshRSS today, CustomCSS config page is blank, and enabling the extension breaks FreshRSS entirely. Downloaded version immediately before this commit and it works as usual
@Alkarex
Copy link
Member

Alkarex commented Nov 23, 2023

Thanks for the heads up.
What FreshRSS version on which setup (Docker image, PHP version...)

@edwrap
Copy link
Author

edwrap commented Nov 23, 2023

Latest FreshRSS stable (1.22.1) nginx/sqlite/PHP version on Debian 12, which is using PHP 8.2

@edwrap
Copy link
Author

edwrap commented Nov 23, 2023

This is working with the FreshRSS edge release - my mistake!

@edwrap edwrap closed this as completed Nov 23, 2023
@Alkarex Alkarex reopened this Nov 23, 2023
@Alkarex
Copy link
Member

Alkarex commented Nov 23, 2023

Let me try to make a better fix. It should work at least with the latest release as well. But I can see that there is first a bit of cleaning to do...

Alkarex added a commit that referenced this issue Nov 23, 2023
@Alkarex
Add PHPStan and other quality checks
b495968 
Similar to FreshRSS core
Contributes to #184
@Alkarex Alkarex mentioned this issue Nov 23, 2023
Merged
1 task
Alkarex added a commit that referenced this issue Nov 24, 2023
@Alkarex
Add PHPStan and other quality checks (#185)
fabd980 
* Add PHPStan and other quality checks
Similar to FreshRSS core
Contributes to #184

* Bump versions

* markdownlint

* Draft of GitHub Actions

* Wrong branch

* Remove wrong tests

* Change path approach

* Move checkout

* cache-dependency-path

* fix rm symbolic

* Remove irrelevant tests

* Fix composer cache path

* Fix hashFiles

* fix shell cache
@rfog
Copy link

rfog commented Dec 14, 2023

The problem is still with FreshRSS 1.22.1 and last commit (6148b58). After uploading the extension and refresh, you get an Error 500. I don't know how to get my PHP version as I'm using a 3rd party hosting.

@Alkarex
Copy link
Member

Alkarex commented Dec 14, 2023

@rfog Please try with our edge version of FreshRSS, which should fix the issue

@Alkarex
Copy link
Member

Alkarex commented Dec 30, 2023

https://github.com/FreshRSS/FreshRSS/releases/tag/1.23.1

@Alkarex Alkarex closed this as completed Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug (confirmed)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Alkarex @rfog @edwrap