-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ImageProxy to pass PHPStan Level 9 #202
Labels
Comments
Merged
This was referenced Feb 29, 2024
Still relevant. See update #269 |
This was referenced Jan 11, 2025
Merged
Some notes on getting PHPStan to work here: #209 (comment) |
See higher up here |
Alkarex
added a commit
that referenced
this issue
Jan 12, 2025
fix #202 Note: breaking changes. Users will have to save their configuration again
Merged
Alkarex
added a commit
that referenced
this issue
Jan 13, 2025
* Update ImageProxy code fix #202 Note: breaking changes. Users will have to save their configuration again * Readme changelog * Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#185 (comment) and follow-up of #201 , #269
ImageProxy does not even pass PHPStan Level 2 at the moment.
Only a couple of files are lacking a little update to pass PHPStan Level 10 for all this Extensions repository:
The problem seems to be that ImageProxy saves the configuration parameters in FreshRSS top level instead of one level down dedicated to extensions
How to work:
git clone https://github.com/FreshRSS/FreshRSS.git git clone https://github.com/FreshRSS/Extensions.git cd Extensions/
Remove those two lines
Extensions/phpstan.dist.neon
Lines 15 to 16 in 15d66ca
The text was updated successfully, but these errors were encountered: