Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ImageProxy to pass PHPStan Level 9 #202

Closed
Alkarex opened this issue Jan 15, 2024 · 3 comments · Fixed by #270
Closed

Update ImageProxy to pass PHPStan Level 9 #202

Alkarex opened this issue Jan 15, 2024 · 3 comments · Fixed by #270
Assignees
Labels

Comments

@Alkarex
Copy link
Member

Alkarex commented Jan 15, 2024

#185 (comment) and follow-up of #201 , #269

ImageProxy does not even pass PHPStan Level 2 at the moment.

Only a couple of files are lacking a little update to pass PHPStan Level 10 for all this Extensions repository:

./xExtension-ImageProxy/configure.phtml
./xExtension-ImageProxy/extension.php

The problem seems to be that ImageProxy saves the configuration parameters in FreshRSS top level instead of one level down dedicated to extensions

How to work:

git clone https://github.com/FreshRSS/FreshRSS.git
git clone https://github.com/FreshRSS/Extensions.git
cd Extensions/

Remove those two lines

- xExtension-ImageProxy/configure.phtml # TODO pass
- xExtension-ImageProxy/extension.php # TODO pass

make test-all
@Alkarex
Copy link
Member Author

Alkarex commented Jan 11, 2025

Still relevant. See update #269

This was referenced Jan 11, 2025
@Frenzie
Copy link
Member

Frenzie commented Jan 12, 2025

Some notes on getting PHPStan to work here: #209 (comment)

@Alkarex
Copy link
Member Author

Alkarex commented Jan 12, 2025

Some notes on getting PHPStan to work

See higher up here

@Alkarex Alkarex assigned Alkarex and unassigned Frenzie Jan 12, 2025
Alkarex added a commit that referenced this issue Jan 12, 2025
fix #202
Note: breaking changes. Users will have to save their configuration again
Alkarex added a commit that referenced this issue Jan 13, 2025
* Update ImageProxy code
fix #202
Note: breaking changes. Users will have to save their configuration again

* Readme changelog

* Fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants