We need to split our big object with grocery lists into separated files, each file = one grocery list object

[atherdon]

i keep it without good task explanation for a reason. want to provoke a discussion here.
Please ask your questions. @uniyalprashant9

[atherdon]

@amogh-jrules as it's a big task - let's go from it. but it pretty simple

[0xamogh]

@atherdon Do we have to write scripts which take in a large object and break it down and generate smaller files?

[atherdon]

if you want - yes. we actually have our generator script - that you can use for this kind of task.
my goal here - to split our old version of file/database into small files in order to easily manipulate them
and by working on this task, same to @uniyalprashant9 - you'll learn about the current structure of grocery lists(which maybe soon will be changed)

[atherdon]

for generator explanation - check Readme file

[atherdon]

@amogh-jrules @uniyalprashant9 please connect together in order to deal with this task. because we need to solve it together - not twice, so it's about collaboration task, not about competition

[0xamogh]

Will do

…

On Fri 31 May, 2019, 8:26 PM Arthur Tkachenko, ***@***.***> wrote: @amogh-jrules <https://github.com/amogh-jrules> @uniyalprashant9 <https://github.com/uniyalprashant9> please connect together in order to deal with this task. because we need to solve it together - not twice, so it's about collaboration task, not about competition — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#424>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHQ22QJFNDLW3IG6C3YGVHLPYE4BXANCNFSM4HRJGMIQ> .

[uniyalprashant9]

We have to write a script for splitting these files
https://github.com/GroceriStar/sd/tree/master/src/data/Grocery ( grocery.json and grocery0.json ) into multiple JSON files each with one element ??

[0xamogh]

Yes that's the goal I guess

…

On Fri 31 May, 2019, 8:41 PM Prashant Uniyal, ***@***.***> wrote: We have to write a script for splitting these files https://github.com/GroceriStar/sd/tree/master/src/data/Grocery ( grocery.json and grocery0.json ) into multiple JSON files each with one element ?? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#424>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHQ22QOJPVEIWZXYDTM7HITPYE5ZPANCNFSM4HRJGMIQ> .

[atherdon]

what is the difference between grocery.json and grocery0? just don't remember

[0xamogh]

I ran it through https://www.diffchecker.com, only one line is different rest all is the same

[atherdon]

got it

[uniyalprashant9]

This should be the desired output or need some changes??
Each file has one element from grocery.JSON and the file name is the same as the name attribute of each element.

[atherdon]

1) can you replace JSON with json 2) did you made it inside of our module? 3) can you open a pull request and so I can publish it on our repository?

…

[atherdon]

other thing looks well(but we'll need to check it with our tests and JSONLint script)

…

[uniyalprashant9]

Ok, I will change JSON to json .
I made that separately to test if it works or not, I will put in our module and open a pull request.

[atherdon]

cool main reason - we need it to work as part of our module, because later we'll be able to change the structure of our data and import it into databases with different structure

…

[uniyalprashant9]

@atherdon I made few changes in the script, now it creates a seperate directory for each object of the same name and put respective elements inside the directory.

If you need all the elements in one folder I will change it again.

I opened a pull request for the same.

[atherdon]

1. We need to create an index.js file and import all of created json files there.
   you can see as example src/files.js so our files will be accessible from the outside
2. we should write tests for all files(connecting them to tests from index.js that we will create)
3. we should add information to our readme - so other team members will know about our changes.
4. how do we can call this script? do we have a package.json script for it?
5. I think that part of your code can be replaced with an actuall code that we have at generator folder right now.

please go from first point, doing them step-by-step and pushing pull requests separately.

[uniyalprashant9]

@atherdon I didn't understand what is to be done in point 1.

I have to make index.js file which will import all the json files that were splitted from the large object file grocery.json and it will return a list of all the elements??

[atherdon]

i think yes, something similar to https://github.com/GroceriStar/sd/blob/master/src/index.js

[uniyalprashant9]

Which ourput is required for 1

A)list of files
or
B)an object that has all the content of the splitted files.
A=>

B=>

[atherdon]

actutally both will be useful :) Make 2 methods but for now we'll use the first one

[uniyalprashant9]

OK i will make the first one as index.js and the second one as indexContent.js

[uniyalprashant9]

For 2, I have made a test.
Please check is it ok, then I will open a new pull request.
Writing test is new for me so it took time. 😅

That error in the screenshot was made intentionally to check if it is working or not. Then I reverted it back and made a final one.

[uniyalprashant9]

@atherdon I have one doubt, I have used mocha for the test , will it get errors when running it in Travis CI?

[uniyalprashant9]

@atherdon Please check my pull request, I have one more test module to upload. 😅

[uniyalprashant9]

I am currently working on readme file.

[uniyalprashant9]

1. We need to create an index.js file and import all of created json files there.
   you can see as example src/files.js so our files will be accessible from the outside
2. we should write tests for all files(connecting them to tests from index.js that we will create)
3. we should add information to our readme - so other team members will know about our changes.
4. how do we can call this script? do we have a package.json script for it?
5. I think that part of your code can be replaced with an actuall code that we have at generator folder right now.

please go from first point, doing them step-by-step and pushing pull requests separately.

I am merging splitObject.js in the existing writeFile.js file in generators and then will do a readme.MD update.

[atherdon]

Ok, but please be careful with changes. Or create tests or ask for advice about tests as well.

[atherdon]

Btw, it's still not clear for me - are we merge your changes or not? @uniyalprashant9 - you made some moves and my head is going around

[uniyalprashant9]

Ok, but please be careful with changes. Or create tests or ask for advice about tests as well.

Yes I will

[uniyalprashant9]

1. We need to create an index.js file and import all of created json files there.
   you can see as example src/files.js so our files will be accessible from the outside
2. we should write tests for all files(connecting them to tests from index.js that we will create)
3. we should add information to our readme - so other team members will know about our changes.
4. how do we can call this script? do we have a package.json script for it?
5. I think that part of your code can be replaced with an actuall code that we have at generator folder right now.

please go from first point, doing them step-by-step and pushing pull requests separately.

splitObject() is in writeFile.js to split json files
getList() and getListContent() are in utils.js to retrive json files.
readme is updated.
how to call those functions is explained in readme.md.
the old splitObject.js is already merged in existing file (writeFile.js)

[uniyalprashant9]

Only test part is remaining.

[uniyalprashant9]

@atherdon

[atherdon]

can you handle a testing part on your own or do you need help with it? we have a pretty cool test folder where you may find some similar tests that you can copy and connect to this task

[uniyalprashant9]

can you handle a testing part on your own or do you need help with it? we have a pretty cool test folder where you may find some similar tests that you can copy and connect to this task

@atherdon Most of the tests are to match the schema of json files, my modules split large json files into single files, retrieve list of files in the directory, they don't need tests I guess splitObject will work on parameters passed.

[atherdon]

yes, that tests for schema. but not only for schemas only. take deeper look

…

[atherdon]

and no guessing - we have tests for that ;)

[atherdon]

@uniyalprashant9 what is left for this task?

[uniyalprashant9]

@atherdon only tests are remaining

[atherdon]

can you do them?

…

[uniyalprashant9]

yes i will :)

[atherdon]

@vadim9999 garb it here too. looks like we almost finished it but i'm have doubts that all of my comments was actually done/implemented

[vadim9999]

ok

[vadim9999]

I think it's done