-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test for getFileInfo #544
test for getFileInfo #544
Conversation
It needs an absolute path instead of relative path. |
Code Climate has analyzed commit 61fdc08 and detected 0 issues on this pull request. View more on Code Climate. |
@atherdon I am stuck at finding the absolute path :( |
hmm, don't worry- it;s a common problem. why not compare it with other tests? did you tried this way? |
i actually think that this is a perfect way to show of how important tests and documentation is. because if you - as creator of this method - cannot deal with it - then something is not ok, right? |
check this and tell me what i should do - try to help you or wait while you will figure it out on your own. check #545 what i will do if i was you - redo that method few times. usually it helps to understand the problem better |
it must work with |
hmm, then google why it can be broken - because travis ci always keeping our back save. this is why we need it - in order to test for different cases and set ups |
still will advice to redo that method. |
yes I am checking that. |
ok, can you sync your fork with our master - because i see some conflicts? |
something is messed up I will pull request again |
#424
Tests for getFileInfo