-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test for getFileInfo and path fix in writeFile.js and src/utils.js #562
Conversation
you rework that method or i should be unhappy?
… |
i am working on it |
then i'm sad... life is not fair for me |
finally, after spending hours on google I made it :) |
looka nixe! |
@vadim9999 please review it |
@uniyalprashant9 did you update the main method or only tests? |
I updated only tests. |
Update utils.js and writeFile.js
while Vadim reviewing your code, upgrade |
`@TODO do we have only one this method or i'm mistaken?` --> yes we have only one method. the whitespaces are auto added from the vscode editor (extension).
@uniyalprashant9 let's also add a backward method, that will combine splited files into big one. But do it in more elegant way. as last attribute - we'll pass a callback, that will operate structure of for example.
for the second case
and i want to do manipulations with structures at callbacks. tell me if something is not clear Plus, in the end it should call a write file for sure... |
and fix these new todos that I just added |
update splitObject
Code Climate has analyzed commit a1a3bad and detected 0 issues on this pull request. View more on Code Climate. |
@atherdon I some made changes please review it. |
waiting for Vadim approval. he is now reviewing PRs, so i can have more free time |
shall we do this in a seperate issue? |
@uniyalprashant9 awesome that you suggest it. create a separated issue, copy-paste this comment there and start to work on it |
Sure 😄 |
@atherdon @vadim9999 The changes I made in writefile.js might resolve issue #559 |
Fixes #424