Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for getFileInfo and path fix in writeFile.js and src/utils.js #562

Merged
merged 24 commits into from
Jun 21, 2019

Conversation

uniyalprashant9
Copy link
Contributor

Fixes #424

@atherdon atherdon requested a review from vadim9999 June 19, 2019 14:39
@uniyalprashant9
Copy link
Contributor Author

Its is working in my system even in longer paths
Screenshot (5)

But path.resolves() fails in resolving paths in travis ci :|
Screenshot (6)

@atherdon
Copy link
Contributor

atherdon commented Jun 19, 2019 via email

@uniyalprashant9
Copy link
Contributor Author

i am working on it

@atherdon
Copy link
Contributor

then i'm sad... life is not fair for me

@uniyalprashant9
Copy link
Contributor Author

finally, after spending hours on google I made it :)

@uniyalprashant9
Copy link
Contributor Author

@atherdon

@atherdon
Copy link
Contributor

looka nixe!

@atherdon
Copy link
Contributor

@vadim9999 please review it

@atherdon
Copy link
Contributor

@uniyalprashant9 did you update the main method or only tests?

@uniyalprashant9
Copy link
Contributor Author

uniyalprashant9 commented Jun 20, 2019

@uniyalprashant9 did you update the main method or only tests?

I updated only tests.
But yes I need to update methods also.

@atherdon
Copy link
Contributor

what i can say...

xxx

@atherdon
Copy link
Contributor

while Vadim reviewing your code, upgrade splitObject i think it can be improved

`@TODO do we have only one this method or i'm mistaken?`
-->  yes we have only one method.

the whitespaces are auto added from the vscode editor (extension).
@atherdon
Copy link
Contributor

@uniyalprashant9 let's also add a backward method, that will combine splited files into big one. But do it in more elegant way. as last attribute - we'll pass a callback, that will operate structure of object inside of that array.

for example.
I want to combine all grocery lists together. but for one case i want to have

- grocery
  - id
  - name
  - ingredients
  - departments
  - purchased

for the second case

- grocery
  - id
  - name
  - items
    - all
    - purchased

and i want to do manipulations with structures at callbacks. tell me if something is not clear

Plus, in the end it should call a write file for sure...

@atherdon
Copy link
Contributor

and fix these new todos that I just added

generator/writeFile.js Outdated Show resolved Hide resolved
generator/writeFile.js Outdated Show resolved Hide resolved
generator/writeFile.js Outdated Show resolved Hide resolved
generator/writeFile.js Outdated Show resolved Hide resolved
update splitObject
@uniyalprashant9 uniyalprashant9 changed the title test for getFileInfo and path fix in writeFIle.js and src/utils.js test for getFileInfo and path fix in writeFile.js and src/utils.js Jun 21, 2019
@codeclimate
Copy link

codeclimate bot commented Jun 21, 2019

Code Climate has analyzed commit a1a3bad and detected 0 issues on this pull request.

View more on Code Climate.

@uniyalprashant9
Copy link
Contributor Author

and fix these new todos that I just added

@atherdon I some made changes please review it.

@atherdon
Copy link
Contributor

waiting for Vadim approval. he is now reviewing PRs, so i can have more free time

@uniyalprashant9
Copy link
Contributor Author

@uniyalprashant9 let's also add a backward method, that will combine splited files into big one. But do it in more elegant way. as last attribute - we'll pass a callback, that will operate structure of object inside of that array.

for example.
I want to combine all grocery lists together. but for one case i want to have

- grocery
  - id
  - name
  - ingredients
  - departments
  - purchased

for the second case

- grocery
  - id
  - name
  - items
    - all
    - purchased

and i want to do manipulations with structures at callbacks. tell me if something is not clear

Plus, in the end it should call a write file for sure...

shall we do this in a seperate issue?

@atherdon
Copy link
Contributor

@uniyalprashant9 awesome that you suggest it. create a separated issue, copy-paste this comment there and start to work on it

@uniyalprashant9
Copy link
Contributor Author

@uniyalprashant9 awesome that you suggest it. create a separated issue, copy-paste this comment there and start to work on it

Sure 😄

@vadim9999 vadim9999 merged commit 0ffc5f2 into Food-Static-Data:master Jun 21, 2019
@uniyalprashant9
Copy link
Contributor Author

@atherdon @vadim9999 The changes I made in writefile.js might resolve issue #559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We need to split our big object with grocery lists into separated files, each file = one grocery list object
3 participants