Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI for password encrypted message functionality #1221

Closed
Tracked by #955
tomholub opened this issue Dec 13, 2021 · 1 comment · Fixed by #1249
Closed
Tracked by #955

UI for password encrypted message functionality #1221

tomholub opened this issue Dec 13, 2021 · 1 comment · Fixed by #1249
Assignees
Labels
actionable PR Submitted PR is submitted for this issue

Comments

@tomholub
Copy link
Collaborator

tomholub commented Dec 13, 2021

part of #955

@tomholub
Copy link
Collaborator Author

tomholub commented Dec 13, 2021

When there is least one recipient that doesn't have any pubkey, currently we don't allow the message to be sent.

For now, if domain of active user is not flowcrypt.com, keep current behavior (because this new functionality will be work-in-progress for a while, we don't want to allow it for external users yet).

Else, in situation when at least one recipient doesn't have pubkey available:

  • add UI (on the top of the message under recipients?) with text: Tap to add password for recipients who don't have encryption set up.. Tapping could produce a modal like Set web portal password\n\nThe recipients will receive a link to read your message on a web portal, where they will need to enter this password.\n\n[input]\n[set] [cancel]. I'm not sure what is the best UI to use here. You can have a look at what browser extension does. After we set it, the text could change to Web portal password added. Tapping it again could maybe allow the user to set another one.
  • when sending message, the password that was entered should be added into Core.composeEmail as pwd, along with the list of public keys
  • if we send a message (to someone without pubkey) and the above was not set, you could produce the same modal that says Enter web portal password.... This time, after tapping ok, the message would get sent (using that password). Cancel would cancel sending, so the user could adjust recipients if they want.

@tomholub tomholub changed the title add UI for upcoming password message functionality add UI for password message functionality + encrypt Dec 13, 2021
@tomholub tomholub changed the title add UI for password message functionality + encrypt UI for password encrypted message functionality Dec 13, 2021
@tomholub tomholub added this to the 0.7.0: Forward milestone Dec 13, 2021
@sosnovsky sosnovsky added the in progress Work on the issue is in progress label Dec 15, 2021
sosnovsky added a commit that referenced this issue Dec 16, 2021
sosnovsky added a commit that referenced this issue Dec 16, 2021
sosnovsky added a commit that referenced this issue Dec 17, 2021
sosnovsky added a commit that referenced this issue Dec 17, 2021
sosnovsky added a commit that referenced this issue Dec 20, 2021
sosnovsky added a commit that referenced this issue Dec 20, 2021
sosnovsky added a commit that referenced this issue Dec 22, 2021
sosnovsky added a commit that referenced this issue Dec 22, 2021
sosnovsky added a commit that referenced this issue Dec 22, 2021
sosnovsky added a commit that referenced this issue Dec 23, 2021
sosnovsky added a commit that referenced this issue Dec 23, 2021
sosnovsky added a commit that referenced this issue Dec 24, 2021
sosnovsky added a commit that referenced this issue Dec 24, 2021
sosnovsky added a commit that referenced this issue Dec 24, 2021
sosnovsky added a commit that referenced this issue Dec 24, 2021
sosnovsky added a commit that referenced this issue Dec 24, 2021
sosnovsky added a commit that referenced this issue Dec 26, 2021
@sosnovsky sosnovsky added PR Submitted PR is submitted for this issue and removed in progress Work on the issue is in progress labels Dec 27, 2021
tomholub pushed a commit that referenced this issue Dec 27, 2021
* #1221 add pwd param to composeEmail

* #1221 update ui

* #1221 update message validation

* #1221 update tests

* #1221 split ComposeMessageService

* #1221 update ui reloading

* #1221 update ui test

* #1221 update tests

* #1221 add check for domain password support

* #1221 improve search handling

* #1221 code updates

* #1221 pr comments updates

* #1221 update emailParts extension

* #1221 fix tests

* #1221 add messagePassword getter

* #1221 message password alert update

* #1221 fix recipient selection crash

* #1221 add ui test for recipient deletion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actionable PR Submitted PR is submitted for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants