Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retrieve id token (or reauth) when sending password-protected message #1222

Closed
Tracked by #955
tomholub opened this issue Dec 13, 2021 · 0 comments · Fixed by #1263
Closed
Tracked by #955

retrieve id token (or reauth) when sending password-protected message #1222

tomholub opened this issue Dec 13, 2021 · 0 comments · Fixed by #1263
Assignees
Labels
actionable PR Submitted PR is submitted for this issue

Comments

@tomholub
Copy link
Collaborator

tomholub commented Dec 13, 2021

part of #955, after #1091 and #1221

When sending password-protected message as described in #1221, we'll soon be uploading the message to FES where it will be served through a web portal. Similar to https://flowcrypt.com/docs/guide/send-and-receive/send-password-protected.html

For this, we'll need an active / not expired id token.

Before sending, please check, using #1221, whether we have an id token that still has at least 5 minutes left before expiring (to account for encrypting / sending etc).

If not (don't have any or it's expired), please show Please log in with Google to continue and then show Google prompt to authenticate (only with id token scope). That will refresh the id token. Once it's fresh, the sending process may continue.

The id token won't actually be used in this issue yet, that will be for another issue.

You can test this in browser extension, which already does this (when sending from flowcrypt.com account).

@tomholub tomholub added this to the 0.7.0: Forward milestone Dec 13, 2021
@tomholub tomholub changed the title retrieve id token (or get a new one) when sending password-protected message retrieve id token (or reauth) when sending password-protected message Dec 21, 2021
@sosnovsky sosnovsky added the in progress Work on the issue is in progress label Dec 30, 2021
@sosnovsky sosnovsky added PR Submitted PR is submitted for this issue and removed in progress Work on the issue is in progress labels Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actionable PR Submitted PR is submitted for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants