-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1221 UI for message passwords #1249
Conversation
# Conflicts: # appium/tests/data/index.ts # appium/tests/specs/live/composeEmail/SendEmailToRecipientWithoutPublicKey.spec.ts
We can merge it, this will take care of it:
There are no customers on flowcrypt.com domain 😃 so we can safely merge it without affecting anyone. // edit - I just saw that the code decides on domain of the recipient, but we should be deciding based on domain of sender. So that the functionality is only available to our team until finalized. It will take more than one PR, and I'd rather merge them gradually instead of waiting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't run app yet - please see code comments.
FlowCrypt/Functionality/Services/Compose Message Service/ComposeMessageContext.swift
Outdated
Show resolved
Hide resolved
FlowCrypt/Functionality/Services/Compose Message Service/ComposeMessageError.swift
Outdated
Show resolved
Hide resolved
FlowCrypt/Functionality/Services/Compose Message Service/ComposeMessageService.swift
Outdated
Show resolved
Hide resolved
FlowCrypt/Functionality/Services/Compose Message Service/ComposeMessageService.swift
Outdated
Show resolved
Hide resolved
FlowCrypt/Functionality/Services/Account Server Services/EnterpriseServerApi.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost perfect, except:
- setting empty string on this modal should not be allowed. I could use cancel for that. So either I enter an actual string, or it should tell me to enter one. Soon there will also be more complex evaluation of password strength, so some way to indicate the input is invalid is needed anyway.
- crash when trying to remove recipient
@tomholub are you able to reproduce it with the latest code? As recipients deletion works well for me - no crash occurred |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Will retry the deletion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixed the issue 👍
This PR adds UI for setting message passwords
close #1221
Tests (delete all except exactly one):
SendEmailToRecipientWithoutPublicKey
test with new password functionalityTo be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):