Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows build issue #5611

Conversation

ioanatflowcrypt
Copy link

@ioanatflowcrypt ioanatflowcrypt commented Feb 21, 2024

This PR fixed build issue in windows system

close #5610 // if this PR closes an issue


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanatflowcrypt
Copy link
Author

ioanatflowcrypt commented Feb 21, 2024

@sosnovsky Maybe better to include below tutorial to install rsync in git bash in our readme?

In windows git bash, rsync is not installed by default and we use rsync in build.sh.

Here's tutorial to install rsync in git bash.

https://www.chrisborkowski.com/git-bash-here-and-rsync-it/

README.md Show resolved Hide resolved
@sosnovsky sosnovsky enabled auto-merge (squash) February 21, 2024 11:33
@sosnovsky
Copy link
Collaborator

@ioanmo226 looks like CI checks are not performed for non-FlowCrypt contributors, probably it'll be easier if you'll just create another PR with your usual account

@ioanmo226 ioanmo226 closed this Feb 21, 2024
auto-merge was automatically disabled February 21, 2024 11:58

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build issue in windows
3 participants