Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows build issue #5611

Closed
wants to merge 3 commits into from
Closed

fix: windows build issue #5611

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74109ba
fix: windows build issue
ioanatflowcrypt Feb 21, 2024
c6ef2ad
feat: updated readme
ioanmo226 Feb 21, 2024
ad88226
fix: remove windows restrictions
ioanmo226 Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ $ npm install
$ npm run build
```

- For building project on Windows we recommend to use [Cygwin](https://www.cygwin.com/) with rsync package.
ioanmo226 marked this conversation as resolved.
Show resolved Hide resolved

After executing the build command, you can find your built project in the `build/chrome-consumer` and `build/firefox-consumer` folders.

> ℹ️ Note: The `build` folder also contains other versions of the browser extension.
Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@
"zxcvbn": "4.4.2"
},
"scripts": {
"build": "./scripts/build.sh",
"build-incremental": "./scripts/build.sh --incremental",
"build-assets-only": "./scripts/build.sh --assets-only",
"build": "sh scripts/build.sh",
"build-incremental": "sh scripts/build.sh --incremental",
"build-assets-only": "sh scripts/build.sh --assets-only",
"pretest": "npm run build --silent && cd conf && node ../build/tooling/tsc-compiler --project tsconfig.test.json && node ../build/tooling/resolve-modules --project tsconfig.test.json",
"pretest-incremental": "npm run build-incremental --silent && cd conf && node ../build/tooling/tsc-compiler --project tsconfig.test.json && node ../build/tooling/resolve-modules --project tsconfig.test.json",
"postinstall": "npm run pretest",
Expand All @@ -85,7 +85,7 @@
"test_ci_chrome_enterprise": "npx ava --timeout=30m --verbose --tap --concurrency=10 build/test/test/source/test.js -- ENTERPRISE-MOCK STANDARD-GROUP | npx tap-xunit > report.xml",
"test_ci_chrome_consumer_flaky": "npx ava --timeout=30m --verbose --tap --concurrency=10 build/test/test/source/test.js -- CONSUMER-MOCK FLAKY-GROUP | npx tap-xunit > report.xml",
"test_ci_chrome_content_scripts": "npx ava --timeout=3m --verbose --tap build/test/test/source/test.js -- CONTENT-SCRIPT-TESTS > report.xml",
"dev_start_gmail_mock_api": "./scripts/build.sh && cd ./conf && node ../build/tooling/tsc-compiler --project tsconfig.test.json && cd .. && node ./build/test/test/source/mock.js",
"dev_start_gmail_mock_api": "sh scripts/build.sh && cd ./conf && node ../build/tooling/tsc-compiler --project tsconfig.test.json && cd .. && node ./build/test/test/source/mock.js",
"run_firefox": "npm run build-incremental && npx web-ext run --source-dir ./build/firefox-consumer/ --firefox-profile ~/.mozilla/firefox/flowcrypt-dev --keep-profile-changes",
"run_firefox_windows": "npm run build-incremental && npx web-ext run --source-dir ./build/firefox-consumer/ --firefox-profile %userprofile%/AppData/Local/Mozilla/Firefox/Profiles/flowcrypt-dev --keep-profile-changes",
"find_unused": "ts-prune -p tsconfig.json | grep -v extension/types | grep -v extension/js/common/core",
Expand Down
Loading