Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build issue in windows #5610

Open
ioanatflowcrypt opened this issue Feb 21, 2024 · 6 comments · May be fixed by #5613
Open

Build issue in windows #5610

ioanatflowcrypt opened this issue Feb 21, 2024 · 6 comments · May be fixed by #5613

Comments

@ioanatflowcrypt
Copy link

When we run npm run build or npm run build-incremental in git bash or something like that, it throws below error.

image

@ioanatflowcrypt
Copy link
Author

In windows git bash, rsync is not installed by default and we use rsync in build.sh.

Here's tutorial to install rsync in git bash.

https://www.chrisborkowski.com/git-bash-here-and-rsync-it/

@sosnovsky
Copy link
Collaborator

In windows git bash, rsync is not installed by default and we use rsync in build.sh.

Here's tutorial to install rsync in git bash.

https://www.chrisborkowski.com/git-bash-here-and-rsync-it/

Did you switch to windows?
This tutorial looks quite complicated, what about using Cygwin which has rsync package (https://cygwin.com/packages/summary/rsync.html)?

@ioanatflowcrypt
Copy link
Author

Using both mac and windows but tried on windows and it threw error.
Haven't used Cygwin yet.

@ioanmo226
Copy link
Collaborator

Just finished checking and seems like good idea to use Cygwin

@sosnovsky
Copy link
Collaborator

Just finished checking and seems like good idea to use Cygwin

Ok, then we can update this line in README https://github.com/FlowCrypt/flowcrypt-browser/blob/master/README.md?plain=1#L22 to 2. To build the project, run the following command:

And before https://github.com/FlowCrypt/flowcrypt-browser/blob/master/README.md?plain=1#L28 add another line:

For building project on Windows we recommend to use Cygwin with rsync package.

@ioanmo226
Copy link
Collaborator

Sounds good

@ioanmo226 ioanmo226 linked a pull request Feb 21, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants