feat: Domain layer implementation for android test run Corellium MVP #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
jan-goral
force-pushed
the
corellium-domain
branch
from
937ea43 to
405da99
Compare
mergify bot
pushed a commit
that referenced
this pull request
May 8, 2021
Related to #1802 This is a bunch of several minor changes cherry-picked from #1897 for splitting code review into smaller parts. * Normalize output lines from Corellium console + unit test * Convert API interfaces to functional * Update adapters implementation to use SAM conversion * Rename API scope TestApk to Apk and expand the interface to meet domain requirements * Fix log parser issues * Add doc for sharding structures * Add `am instrument` status codes constants Merging this one will make the #1897 thinner.
piotradamczyk5
previously requested changes
May 10, 2021
corellium/adapter/src/test/kotlin/flank/corellium/adapter/Example.kt
Outdated
Show resolved
Hide resolved
jan-goral
force-pushed
the
corellium-domain
branch
2 times, most recently
from
7285ae3 to
36f3e18
Compare
|
Timestamp: 2021-05-19 15:49:07 |
jan-goral
force-pushed
the
corellium-domain
branch
2 times, most recently
from
47cbd31 to
76adaf7
Compare
mergify bot
pushed a commit
that referenced
this pull request
May 14, 2021
Related to #1802 This is a bunch of several minor changes cherry-picked from #1897 for splitting code review into smaller parts. * Add missing `build.gradle.kts` for `:corellium:junit` module * Fix some names * Organize imports * Add details parsing to `am instrument log` parser * Fix method signatures ## Test Plan > How do we know the code works? Unit tests pass.
jan-goral
force-pushed
the
corellium-domain
branch
2 times, most recently
from
ed938d1 to
08599d7
Compare
jan-goral
force-pushed
the
corellium-domain
branch
3 times, most recently
from
29e2e56 to
4cfbfcb
Compare
jan-goral
changed the title
jan-goral
changed the title
pawelpasterz
approved these changes
May 19, 2021
adamfilipow92
approved these changes
May 19, 2021
bootstraponline
force-pushed
the
corellium-domain
branch
from
b341cda to
c0193c9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1802
This PR adds a domain logic for
RunTestCorelliumAndroid.List of features:
What is currently not supported:
Module README.md
Test Plan
Unit tests pass.
$ flank corellium test android run -c="flank-corellium-android.yml"is invoking a fully integrated feature.Checklist