refactor: Move am instrument commad formatter to dedicated module #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Timestamp: 2021-05-20 11:43:06 |
bootstraponline
force-pushed
the
corellium-domain
branch
from
b341cda to
c0193c9
Compare
jan-goral
force-pushed
the
corellium-execute-test-design-fix
branch
from
66a5cc6 to
e9982f2
Compare
jan-goral
requested review from
Sloox,
adamfilipow92,
zuziaka,
pawelpasterz and
piotradamczyk5
jan-goral
changed the title
bootstraponline
force-pushed
the
corellium-execute-test-design-fix
branch
from
e9982f2 to
22ce8a5
Compare
adamfilipow92
approved these changes
May 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes inconsequence in the
AndroidTestPlanAPI whereAndroidTestPlan.Executeis receiving structured shards as input but producing rawam instrument -r -wlog lines as output.As a result of this fix:
AndroidTestPlan.Executeis normalized to operate on raw input and output.prepareRunCommandis renamed toformatAmInstrumentCommandand moved to:corellium:instrument:logmodule so the adapter layer is a slightly thinner.:corellium:logis moved to:corellium:instrument:logfor consistency.formatAmInstrumentCommandis moved from theExecuteAndroidTestPlanadapter to theExecuteTestsstep, so the domain logic is controlling a little bit more.