fix: Several minor corellium changes - part 2. #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add missing build.gradle.kts for junit module * Fix some names * Organize imports * Add details parsing am instrument log parser * Fix method signatures
jan-goral
requested review from
Sloox,
zuziaka,
pawelpasterz,
adamfilipow92 and
piotradamczyk5
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Timestamp: 2021-05-14 14:13:09 |
jan-goral
force-pushed
the
1802_Corellium_fixes_part_2
branch
from
bea9bdb to
4864c90
Compare
adamfilipow92
approved these changes
May 14, 2021
Sloox
approved these changes
May 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1802
This is a bunch of several minor changes cherry-picked from #1897 for splitting code review into smaller parts.
build.gradle.ktsfor:corellium:junitmoduleam instrument logparserTest Plan
Unit tests pass.