Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structural output - CancelLastRun #1844

Closed
jan-goral opened this issue Apr 26, 2021 · 0 comments · Fixed by #1902
Closed

Structural output - CancelLastRun #1844

jan-goral opened this issue Apr 26, 2021 · 0 comments · Fixed by #1902
Assignees
@piotradamczyk5
Labels
Feature Tiger 🐯

Comments

@jan-goral
Copy link
Contributor

Plan

According to the specification described in epic #1728, implement the structural output for the command and move the console logging to layer CLI.

Command

CancelLastRun
@piotradamczyk5 piotradamczyk5 self-assigned this May 6, 2021
@pawelpasterz pawelpasterz mentioned this issue May 7, 2021
Closed
@piotradamczyk5 piotradamczyk5 mentioned this issue May 7, 2021
Merged
1 task
@mergify mergify bot closed this as completed in #1902 May 10, 2021
mergify bot pushed a commit that referenced this issue May 10, 2021
@piotradamczyk5
refactor: Structural output cancel last run (#1902)
65a49c9 
Fixes #1844

## Test Plan
> How do we know the code works?

- Code is refactored according to description in #1844
- `flank firebase cancel` command works like previously

## Checklist

- [x] Unit tested
@piotradamczyk5 piotradamczyk5 mentioned this issue May 10, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piotradamczyk5 piotradamczyk5

Labels
Feature Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Structural output cancel last run Flank/flank
2 participants
@jan-goral @piotradamczyk5