-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Structural output cancel last run #1902
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Timestamp: 2021-05-10 06:45:15 |
42dacc1
to
5f36a04
Compare
adamfilipow92
approved these changes
May 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Code looks good
- Output also
Test output
/Users/adamfilipowicz/Repos/flank
version: local_snapshot
revision: 5f36a045f50ffcb7f5f205d58fb210d23e388833
session id: 29bd2d98-a605-41a5-a234-31d233ca4bf7
AndroidArgs
gcloud:
results-bucket: test-lab-v9cn46bb990nx-kz69ymd4nm9aq
results-dir: 2021-05-08_13-48-56.490151_UMfY
record-video: false
timeout: 15m
async: false
client-details:
network-profile: null
results-history-name: null
# Android gcloud
app: /Users/adamfilipowicz/Repos/flank/test_runner/src/test/kotlin/ftl/fixtures/tmp/apk/app-debug.apk
test: /Users/adamfilipowicz/Repos/flank/test_runner/src/test/kotlin/ftl/fixtures/tmp/apk/app-single-success-debug-androidTest.apk
additional-apks:
auto-google-login: false
use-orchestrator: true
directories-to-pull:
grant-permissions: all
type: null
other-files:
scenario-numbers:
scenario-labels:
obb-files:
obb-names:
performance-metrics: false
num-uniform-shards: null
test-runner-class: null
test-targets:
robo-directives:
robo-script: null
device:
- model: NexusLowRes
version: 28
locale: en
orientation: portrait
num-flaky-test-attempts: 0
test-targets-for-shard:
fail-fast: false
flank:
max-test-shards: 1
shard-time: -1
num-test-runs: 1
smart-flank-gcs-path:
smart-flank-disable-upload: false
default-test-time: 120.0
use-average-test-time-for-new-tests: false
files-to-download:
test-targets-always-run:
disable-sharding: true
project: flank-open-source
local-result-dir: results
full-junit-result: false
# Android Flank Yml
keep-file-path: false
additional-app-test-apks:
run-timeout: -1
legacy-junit-result: false
ignore-failed-tests: false
output-style: single
disable-results-upload: false
default-class-test-time: 240.0
disable-usage-statistics: false
output-report: json
skip-config-validation: false
custom-sharding-json:
RunTests
Saved 1 shards to /Users/adamfilipowicz/Repos/flank/results/2021-05-08_13-48-56.490151_UMfY/android_shards.json
Uploading [android_shards.json] to https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2021-05-08_13-48-56.490151_UMfY/...
Uploading [app-debug.apk] to https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2021-05-08_13-48-56.490151_UMfY/...
Uploading [app-single-success-debug-androidTest.apk] to https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2021-05-08_13-48-56.490151_UMfY/...
1 test / 1 shard
Uploading [session_id.txt] to https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2021-05-08_13-48-56.490151_UMfY/...
1 matrix ids created in 0m 6s
Raw results will be stored in your GCS bucket at [https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2021-05-08_13-48-56.490151_UMfY]
Matrices webLink
matrix-3sb8kr6wuro89 https://console.firebase.google.com/project/flank-open-source/testlab/histories/bh.da0c237aaa33732/matrices/4758971913501372134/executions/bs.52ac0cdefb2f392e
3m 17s Test executions status: FINISHED:1
3m 17s matrix-3sb8kr6wuro89 FINISHED
FetchArtifacts
Updating matrix file
CostReport
Virtual devices
$0.02 for 1m
Uploading [CostReport.txt] to https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2021-05-08_13-48-56.490151_UMfY/...
MatrixResultsReport
1 / 1 (100.00%)
┌─────────┬──────────────────────┬───────────────┬────────────────────────────┬────────────────────────────────┐
│ OUTCOME │ MATRIX ID │ APP NAME │ TEST AXIS VALUE │ TEST DETAILS │
├─────────┼──────────────────────┼───────────────┼────────────────────────────┼────────────────────────────────┤
│ success │ matrix-3sb8kr6wuro89 │ app-debug.apk │ NexusLowRes-28-en-portrait │ 1 test cases passed, 1 skipped │
└─────────┴──────────────────────┴───────────────┴────────────────────────────┴────────────────────────────────┘
Uploading [MatrixResultsReport.txt] to https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2021-05-08_13-48-56.490151_UMfY/...
Uploading [JUnitReport.xml] to https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2021-05-08_13-48-56.490151_UMfY/...
Actual shard times:
Shard 0: Expected: 0s, Actual: 2s, Diff: 2s
Uploading [matrix_ids.json] to https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2021-05-08_13-48-56.490151_UMfY/...
Matrices webLink
matrix-3sb8kr6wuro89 https://console.firebase.google.com/project/flank-open-source/testlab/histories/bh.da0c237aaa33732/matrices/4758971913501372134/executions/bs.52ac0cdefb2f392e
Uploading [outputReport.json] to https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2021-05-08_13-48-56.490151_UMfY/...
Total run duration: 3m 42s
- Preparation: 0m 6s
- Running tests: 0m 8s
- Executing matrices: 3m 17s
- Generating reports: 0m 6s
Process finished with exit code 0
5f36a04
to
85e6a54
Compare
pawelpasterz
approved these changes
May 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1844
Test Plan
flank firebase cancel
command works like previouslyChecklist