refactor: Structural output orientations #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotradamczyk5
requested review from
bootstraponline,
Sloox,
zuziaka,
pawelpasterz,
jan-goral and
adamfilipow92
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
piotradamczyk5
force-pushed
the
1861_1857_output_orientations
branch
from
eeb0b30 to
b9a2bd9
Compare
|
Timestamp: 2021-05-11 12:00:46 |
bootstraponline
force-pushed
the
1861_1857_output_orientations
branch
from
b9a2bd9 to
3e10854
Compare
bootstraponline
force-pushed
the
1861_1857_output_orientations
branch
from
3e10854 to
c657ca2
Compare
bootstraponline
force-pushed
the
1861_1857_output_orientations
branch
from
c657ca2 to
c409718
Compare
adamfilipow92
approved these changes
May 11, 2021
There was a problem hiding this comment.
- Code and output looks good
┌────────────────┬───────────┬─────────┐
│ ORIENTATION_ID │ NAME │ TAG │
├────────────────┼───────────┼─────────┤
│ landscape │ Landscape │ │
│ portrait │ Portrait │ default │
│ default │ Default │ │
└────────────────┴───────────┴─────────┘
Sloox
approved these changes
May 11, 2021
|
|
||
| override val out = outputLogger { | ||
| @Suppress("UNCHECKED_CAST") | ||
| (this as? List<Orientation>)?.toCliTable() ?: throwUnknownType() |
There was a problem hiding this comment.
Actual a neat way alternative 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1857
Fixes #1861
Test Plan
flank firebase ios|android screen-orientations listworks like previouslyChecklist