Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests on Windows #1134

Closed
Sloox opened this issue Sep 21, 2020 · 5 comments
Closed

Integration tests on Windows #1134

Sloox opened this issue Sep 21, 2020 · 5 comments
Labels
Feature Tiger 🐯

Comments

@Sloox
Copy link
Contributor

Sloox commented Sep 21, 2020

As a developer, I want to have integration tests running on Windows workflow so I can guarantee Flank runs across all common operating systems and works as intended.

Is your feature request related to a problem? Please describe.
Currently Integration task workflow encounters errors and needs to be fixed.

Describe the solution you'd like
Integration tests running on the windows workflow
@Sloox Sloox mentioned this issue Sep 21, 2020
Merged
@Sloox
Copy link
Contributor Author

Sloox commented Sep 22, 2020

@bootstraponline @jan-gogo can we confirm that this might not be necessary?

@Sloox Sloox self-assigned this Sep 22, 2020
@bootstraponline
Copy link
Contributor

@Sloox I think we want to ensure all the integration tests pass on native Windows. This matches the platform support provided by gcloud CLI.

@Sloox
Copy link
Contributor Author

Sloox commented Sep 29, 2020

The ticket which has successfully been merged #1140 has shown that at a minimum Flank will work with the WSL. The ticket is now blocked by the investigation done into : #1172

This was referenced Oct 20, 2020
Merged
Merged
@Sloox Sloox removed their assignment Nov 3, 2020
@Sloox
Copy link
Contributor Author

Sloox commented Nov 3, 2020

@piotradamczyk5 or @adamfilipowicz92 is this a duplicate ticket now?

@Sloox Sloox mentioned this issue Nov 3, 2020
Closed
@adamfilipow92
Copy link
Contributor

@Sloox I think yes, maybe we should close this ticket.

@piotradamczyk5 piotradamczyk5 mentioned this issue Dec 8, 2020
Merged
7 tasks
piotradamczyk5 added a commit that referenced this issue Dec 14, 2020
@piotradamczyk5
ci: Get rid of binaries submodule (#1385)
fd2c0a6 
Fixes #896

This PR delete submodule for [binaries ](https://github.com/Flank/binaries) and download them at runtime from [release page ](https://github.com/Flank/binaries/releases) based on os system

## Test Plan
> How do we know the code works?

`macOs` -> all should work by default because previously binaries were not copied on macOS
`linux` -> it download binaries from [release page](https://github.com/Flank/binaries/releases) at runtime to `<user_home>/.flank` directory and unpack them 
`windows` -> it works similar to `linux` version, however, full support will be available after #1134 

All tests should work properly

## Checklist

- [x] Documented
- [x] Unit tested
- [x] Downloading binaries for Linux and Windows at runtime
- [x] Create binaries release for Linux and Windows
- [x] Update binaries assets after each change on binaries repo [release page](https://github.com/Flank/binaries/releases) >> [PR](Flank/binaries#4)
- [x] Delete submodule
- [x] Update Github Actions to do not checkout submodules
Sloox added a commit that referenced this issue Mar 22, 2021
@Sloox
Merge branch 'master' into #1134-update-llvm-windows
c8e1058
Sloox added a commit that referenced this issue Mar 22, 2021
@Sloox
Merge branch '#1134-update-llvm-windows' of https://github.com/Flank/…
63d8c4a 
…flank into #1134-update-llvm-windows
Sloox added a commit that referenced this issue Mar 22, 2021
@Sloox
Merge branch 'master' into #1134-update-llvm-windows
31a0ea8
@Sloox Sloox mentioned this issue Mar 22, 2021
Merged
Sloox added a commit that referenced this issue Mar 24, 2021
@Sloox
Merge branch 'master' into #1134-update-llvm-windows
42e1645
Sloox added a commit that referenced this issue Mar 24, 2021
@Sloox
Merge branch 'master' into #1134-update-llvm-windows
c66fe3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bootstraponline @Sloox @adamfilipow92