-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Rewrite scripts to Kotlin #1246
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1246 +/- ##
============================================
- Coverage 79.66% 79.65% -0.01%
Complexity 724 724
============================================
Files 235 235
Lines 4489 4498 +9
Branches 771 773 +2
============================================
+ Hits 3576 3583 +7
- Misses 514 515 +1
- Partials 399 400 +1 |
|
3ba1862
to
3da60a3
Compare
PR for binaries |
a32bccd
to
0e64c91
Compare
@Mergifyio rebase |
Command
|
ba927aa
to
f45a3c5
Compare
b55718b
to
e95bb0d
Compare
@Mergifyio refresh |
Command
|
c350f97
to
511235b
Compare
b897aab
to
c065c0b
Compare
I think link is not valid anymore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementing logic code directly inside CliKt commands breaks the separation of concerns, and makes it harder to read, because of object-oriented API overhead. But this is a huge PR, also required for windows os. I can consider to approve it now and refactor a little later.
19cb73e
to
c6cd1f2
Compare
Timestamp: 2020-11-02 12:24:10 |
I will create a ticket to fix the integration test on Windows later on |
Fixes #1178
Test Plan
Scripts are executed properly on macOS, Linux, Windows.
To run scripts use proper
.sh
or.bat
fileKotlin
v1.4
must be installedWarning
Kotlin scripts have problems with caching, often scripts don't notice changes so a good way to have always "fresh" script is reset scripts cache on every run. This problem and solution is documented here.
Checklist