Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port bash scripts to Kotlin #1178

Closed
15 tasks done
adamfilipow92 opened this issue Oct 1, 2020 · 2 comments · Fixed by #1246
Closed
15 tasks done

Port bash scripts to Kotlin #1178

adamfilipow92 opened this issue Oct 1, 2020 · 2 comments · Fixed by #1246

Comments

@adamfilipow92
Copy link
Contributor

adamfilipow92 commented Oct 1, 2020

Author the user story for this feature

As a flank developer, I want to use have Kotlin scripts instead of bash scripts so I can easily write new, understand existing and easily use it on all platforms.

Is your feature request related to a problem? Please describe.

We had a problem with port update_flank.sh to windows bat script, moving them to Kotlin should be easiest and more readable.

Describe the solution you'd like
Port bash scripts to kotlin scripts

  • ./test_runner/bash/update_flank.sh

  • ./test_runner/src/test/kotlin/ftl/fixtures/tmp/gohello/build.sh (this is same as ./test_projects/gohello/build.sh)

  • ./flank-scripts/bash/buildFlankScripts.sh

  • ./test_runner/src/main/resources/binaries/update.sh

  • ./test_projects/ops.sh (many functions)

  • ./test_projects/gohello/build.sh (with possibility to change gohello path)

  • ./test_projects/android/ops.sh (many functions)

  • ./test_projects/android/bash/test_filters.sh.

  • ./test_projects/ios/EarlGreyExample/ops.sh (many functions)

  • ./test_projects/ios/EarlGreyExample/build_example.sh

  • ./test_projects/ios/EarlGreyExample/universal_framework.sh

  • ./test_projects/ios/EarlGreyExample/run_ftl_local.sh

  • ./test_projects/ios/EarlGreyExample/build_ftl.sh

  • ./firebase_apis/generate_java_client.sh

  • ./firebase_apis/update_api_json.sh

@Sloox
Copy link
Contributor

Sloox commented Oct 1, 2020

Are we going to include all bashScripts?
We could make use of : https://www.kotlinresources.com/library/kscript/
Its already used in the Github action for scripting. Works very well.

@bootstraponline
Copy link
Contributor

yeah let's fully move away from Bash in favor of Kotlin. I think this will set the project up for success going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants