Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Windows Updates For Integration Tests #1717

Merged
merged 11 commits into from
Mar 24, 2021
Merged

feat: Windows Updates For Integration Tests #1717

merged 11 commits into from
Mar 24, 2021

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented Mar 22, 2021

Part 1 of the fixes for integration tests.

Binary updates.

Test Plan

How do we know the code works?
Again it doesn't. This just allows swift-demangle and nm.exe to be available to be used.

@Sloox Sloox added the Feature label Mar 22, 2021
@Sloox Sloox self-assigned this Mar 22, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Sloox Sloox marked this pull request as draft March 22, 2021 09:28
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2021 •
edited
Loading

Timestamp: 2021-03-24 12:20:04
Buildscan url for ubuntu-workflow run 682984794
https://gradle.com/s/swd3ka7ynh3p6

@Sloox Sloox requested a review from jan-goral March 22, 2021 10:14
@Sloox
Copy link
Contributor Author

Sloox commented Mar 22, 2021

@flank-it

@Flank Flank deleted a comment from github-actions bot Mar 22, 2021
@Sloox Sloox marked this pull request as ready for review March 22, 2021 15:15
@Sloox Sloox requested a review from piotradamczyk5 March 22, 2021 16:44
@Sloox Sloox requested a review from piotradamczyk5 March 23, 2021 08:25
@bootstraponline bootstraponline force-pushed the #1134-update-llvm-windows branch from 31a0ea8 to 3874ce1 Compare March 23, 2021 08:32
@Flank Flank deleted a comment from github-actions bot Mar 23, 2021
@Sloox
Copy link
Contributor Author

Sloox commented Mar 23, 2021

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2021 •
edited
Loading

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status success - Build scan: https://gradle.com/s/zqnc6lmual6kg
Linux status success - Build scan: https://gradle.com/s/bnt7cgpig3lhe
Workflow run https://github.com/Flank/flank/actions/runs/678925734

@bootstraponline bootstraponline force-pushed the #1134-update-llvm-windows branch from 3874ce1 to 024a027 Compare March 23, 2021 12:13
@bootstraponline bootstraponline force-pushed the #1134-update-llvm-windows branch from 024a027 to 3810bca Compare March 23, 2021 15:24
@Sloox Sloox enabled auto-merge (squash) March 24, 2021 11:47
adamfilipow92
adamfilipow92 approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code looks good
  • Tests pass

@Sloox Sloox merged commit 7e86a53 into master Mar 24, 2021
@Sloox Sloox deleted the #1134-update-llvm-windows branch March 24, 2021 12:25
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@zuziaka zuziaka zuziaka approved these changes

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

@jan-goral jan-goral Awaiting requested review from jan-goral

@piotradamczyk5 piotradamczyk5 Awaiting requested review from piotradamczyk5

Assignees

@Sloox Sloox

Labels
Feature Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sloox @zuziaka @adamfilipow92 @piotradamczyk5