Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Clean up randomElements() and randomElement() #639

Merged
merged 22 commits into from
May 1, 2023

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Apr 27, 2023

What is the reason for this PR?

  • cleans up randomElements() and randomElement()

Blocks #620.

Author's checklist

Summary of changes

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@localheinz localheinz marked this pull request as ready for review April 27, 2023 15:11
@localheinz localheinz changed the title Fix: Clean up randomElements() Fix: Clean up randomElements() and randomElement() Apr 27, 2023
@localheinz localheinz marked this pull request as draft April 27, 2023 15:20
@localheinz localheinz marked this pull request as ready for review April 27, 2023 15:26
@localheinz localheinz added the bug Something isn't working label Apr 27, 2023
@localheinz localheinz removed their assignment Apr 27, 2023
@bram-pkg bram-pkg merged commit ddb0390 into FakerPHP:main May 1, 2023
@localheinz localheinz mentioned this pull request May 1, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants