Fix: Return early

FakerPHP · Apr 27, 2023 · 1bd434f · 1bd434f
1 parent 542181c
commit 1bd434f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/psalm.baseline.xml b/psalm.baseline.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="5.7.7@e028ba46ba0d7f9a78bc3201c251e137383e145f">
+<files psalm-version="5.9.0@8b9ad1eb9e8b7d3101f949291da2b9f7767cd163">
   <file src="src/Faker/Calculator/Luhn.php">
     <InvalidReturnStatement>
       <code>0</code>
@@ -140,11 +140,8 @@
   </file>
   <file src="src/Faker/Provider/Base.php">
     <InvalidArgument>
-      <code><![CDATA[[static::class, 'randomDigit']]]></code>
+      <code>[static::class, 'randomDigit']</code>
     </InvalidArgument>
-    <NoValue>
-      <code>$array</code>
-    </NoValue>
     <UndefinedDocblockClass>
       <code>Closure</code>
     </UndefinedDocblockClass>

diff --git a/src/Faker/Provider/Base.php b/src/Faker/Provider/Base.php
@@ -240,7 +240,11 @@ public static function randomElements($array = ['a', 'b', 'c'], $count = 1, $all
      */
     public static function randomElement($array = ['a', 'b', 'c'])
     {
-        if (!$array || ($array instanceof \Traversable && !count($array))) {
+        if ([] === $array) {
+            return null;
+        }
+
+        if ($array instanceof \Traversable && !count($array)) {
             return null;
         }