Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Reject invalid arguments #642

Merged
merged 1 commit into from
May 2, 2023
Merged

Fix: Reject invalid arguments #642

merged 1 commit into from
May 2, 2023

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented May 1, 2023 •
edited
Loading

What is the reason for this PR?

This pull request

  • rejects invalid arguments passed to randomElement() and randomElements()

Follows #639.

Author's checklist

Summary of changes

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

pimjansen
pimjansen approved these changes May 2, 2023
View reviewed changes
Copy link

@pimjansen pimjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@localheinz localheinz merged commit cd773f4 into FakerPHP:main May 2, 2023
@localheinz
Copy link
Member Author

Thank you, @pimjansen!

@localheinz localheinz deleted the fix/reject branch May 2, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pimjansen pimjansen pimjansen approved these changes

@bram-pkg bram-pkg Awaiting requested review from bram-pkg

Assignees

@pimjansen pimjansen

@bram-pkg bram-pkg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@localheinz @pimjansen @bram-pkg