Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: fix bgp_best_selection heap-use-after-free #14894

Merged
merged 1 commit into from
Nov 29, 2023

bgpd: fix bgp_best_selection heap-use-after-free

9561f96
Select commit
Loading
Failed to load commit list.
Merged

bgpd: fix bgp_best_selection heap-use-after-free #14894

bgpd: fix bgp_best_selection heap-use-after-free
9561f96
Select commit
Loading
Failed to load commit list.
NetDEF CI Pull Requests Testing / TopoTests Ubuntu 18.04 i386 Part 8 succeeded Nov 28, 2023 in 50m 1s

Execution finished at mininet2518 after 2959.862 seconds

Bamboo CI Link
Execution details at https://ci1.netdef.org/browse/FRR-PULLREQ3-TOPO8U18I386-847

Execution Summary

Failures
All tests passed

Success and Not classified
✔️ multicast_pim6_sm_topo1.test_multicast_pim6_sm1 test_multicast_data_traffic_static_RP_send_traffic_then_join_p0 (41.331 s)
✔️ multicast_pim6_sm_topo1.test_multicast_pim6_sm1 test_verify_mroute_when_receiver_is_outside_frr_p0 (31.830 s)
✔️ multicast_pim6_sm_topo1.test_multicast_pim6_sm1 test_verify_mroute_when_frr_is_transit_router_p2 (18.568 s)
✔️ multicast_pim6_sm_topo1.test_multicast_pim6_sm1 test_verify_mroute_when_RP_unreachable_p1 (8.100 s)
✔️ multicast_pim6_sm_topo1.test_multicast_pim6_sm1 test_modify_mld_query_timer_p0 (25.484 s)
✔️ multicast_pim6_sm_topo1.test_multicast_pim6_sm1 test_modify_mld_max_query_response_timer_p0 (8.745 s)
✔️ multicast_pim6_sm_topo1.test_multicast_pim6_sm1 test_verify_impact_on_multicast_traffic_when_RP_removed_p0 (21.838 s)
✔️ multicast_pim6_sm_topo1.test_multicast_pim6_sm2 test_clear_mroute_and_verify_multicast_data_p0 (236.773 s)
✔️ multicast_pim6_sm_topo1.test_multicast_pim6_sm2 test_verify_SPT_switchover_when_RPT_and_SPT_path_is_different_p0 (12.576 s)
✔️ multicast_pim6_static_rp_topo1.test_multicast_pim6_static_rp1 test_pim6_add_delete_static_RP_p0 (29.323 s)
✔️ multicast_pim6_static_rp_topo1.test_multicast_pim6_static_rp1 test_pim6_SPT_RPT_path_same_p1 (6.953 s)
✔️ multicast_pim6_static_rp_topo1.test_multicast_pim6_static_rp1 test_pim6_RP_configured_as_LHR_p1 (10.480 s)
✔️ multicast_pim6_static_rp_topo1.test_multicast_pim6_static_rp1 test_pim6_RP_configured_as_FHR_p1 (3.720 s)
✔️ multicast_pim6_static_rp_topo1.test_multicast_pim6_static_rp1 test_pim6_SPT_RPT_path_different_p1 (4.516 s)
✔️ multicast_pim6_static_rp_topo1.test_multicast_pim6_static_rp1 test_pim6_send_join_on_higher_preffered_rp_p1 (9.400 s)
✔️ multicast_pim6_static_rp_topo1.test_multicast_pim6_static_rp2 test_pim6_multiple_groups_same_RP_address_p2 (90.426 s)
✔️ multicast_pim6_static_rp_topo1.test_multicast_pim6_static_rp2 test_pim6_multiple_groups_different_RP_address_p2 (63.808 s)
✔️ multicast_pim6_static_rp_topo1.test_multicast_pim6_static_rp2 test_pim6_delete_RP_shut_noshut_upstream_interface_p1 (8.372 s)
✔️ multicast_pim_bsm_topo1.test_mcast_pim_bsmp_01 test_BSR_higher_prefer_ip_p0 (45.223 s)
✔️ multicast_pim_bsm_topo1.test_mcast_pim_bsmp_01 test_BSR_CRP_with_blackhole_address_p1 (11.940 s)
✔️ multicast_pim_bsm_topo1.test_mcast_pim_bsmp_01 test_new_router_fwd_p0 (35.732 s)
✔️ multicast_pim_bsm_topo1.test_mcast_pim_bsmp_01 test_int_bsm_config_p1 (54.613 s)
✔️ multicast_pim_bsm_topo1.test_mcast_pim_bsmp_01 test_static_rp_override_p1 (11.881 s)
✔️ multicast_pim_bsm_topo1.test_mcast_pim_bsmp_01 test_BSM_timeout_p0 (11.159 s)
✔️ multicast_pim_bsm_topo1.test_mcast_pim_bsmp_01 test_iif_join_state_p0 (14.283 s)
✔️ multicast_pim_bsm_topo2.test_mcast_pim_bsmp_02 test_starg_mroute_p0 (27.934 s)
✔️ multicast_pim_bsm_topo2.test_mcast_pim_bsmp_02 test_overlapping_group_p0 (13.072 s)
✔️ multicast_pim_bsm_topo2.test_mcast_pim_bsmp_02 test_RP_priority_p0 (15.440 s)
✔️ multicast_pim_bsm_topo2.test_mcast_pim_bsmp_02 test_BSR_election_p0 (14.207 s)
✔️ multicast_pim_bsm_topo2.test_mcast_pim_bsmp_02 test_RP_hash_p0 (11.019 s)
✔️ multicast_pim_bsm_topo2.test_mcast_pim_bsmp_02 test_BSM_fragmentation_p1 (11.652 s)
✔️ multicast_pim_bsm_topo2.test_mcast_pim_bsmp_02 test_RP_with_all_ip_octet_p1 (10.715 s)
✔️ multicast_pim_dr_nondr_test.test_pim_dr_nondr_with_ospf_topo2 test_configuring_igmp_local_join_on_reciever_dr_non_dr_nodes_p1 (34.763 s)
✔️ multicast_pim_dr_nondr_test.test_pim_dr_nondr_with_static_routes_topo1 test_pim_source_dr_functionality_while_rebooting_dr_non_dr_nodes_p1 (92.596 s)
✔️ multicast_pim_dr_nondr_test.test_pim_dr_nondr_with_transit_router_topo3 test_mroute_when_transit_router_present_between_rp_and_source_dr_p1 (31.483 s)
✔️ multicast_pim_sm_topo1.test_multicast_pim_sm_topo1 test_multicast_data_traffic_static_RP_send_join_then_traffic_p0 (28.395 s)
✔️ multicast_pim_sm_topo1.test_multicast_pim_sm_topo1 test_multicast_data_traffic_static_RP_send_traffic_then_join_p0 (9.009 s)
✔️ multicast_pim_sm_topo1.test_multicast_pim_sm_topo1 test_clear_pim_neighbors_and_mroute_p0 (10.098 s)
✔️ multicast_pim_sm_topo1.test_multicast_pim_sm_topo1 test_verify_mroute_when_same_receiver_in_FHR_LHR_and_RP_p0 (17.098 s)
✔️ multicast_pim_sm_topo1.test_multicast_pim_sm_topo1 test_verify_mroute_when_same_receiver_joining_5_diff_sources_p0 (13.866 s)
✔️ multicast_pim_sm_topo1.test_multicast_pim_sm_topo1 test_verify_mroute_when_frr_is_transit_router_p2 (46.156 s)
✔️ multicast_pim_sm_topo1.test_multicast_pim_sm_topo1 test_verify_mroute_when_RP_unreachable_p1 (28.020 s)
✔️ multicast_pim_sm_topo1.test_multicast_pim_sm_topo1 test_modify_igmp_query_timer_p0 (9.486 s)
✔️ multicast_pim_sm_topo1.test_multicast_pim_sm_topo1 test_modify_igmp_max_query_response_timer_p0 (13.130 s)
✔️ multicast_pim_sm_topo2.test_multicast_pim_sm_topo2 test_verify_mroute_and_traffic_when_pimd_restarted_p2 (63.441 s)
✔️ multicast_pim_sm_topo2.test_multicast_pim_sm_topo2 test_verify_mroute_and_traffic_when_frr_restarted_p2 (47.094 s)
✔️ multicast_pim_sm_topo2.test_multicast_pim_sm_topo2 test_verify_SPT_switchover_when_RPT_and_SPT_path_is_different_p0 (26.544 s)
✔️ multicast_pim_sm_topo2.test_multicast_pim_sm_topo2 test_verify_mroute_after_shut_noshut_of_upstream_interface_p1 (12.383 s)
✔️ multicast_pim_sm_topo2.test_multicast_pim_sm_topo2 test_verify_mroute_when_receiver_is_outside_frr_p0 (18.328 s)
✔️ multicast_pim_sm_topo2.test_multicast_pim_sm_topo2 test_verify_mroute_when_FRR_is_FHR_and_LHR_p0 (10.358 s)
✔️ multicast_pim_sm_topo2.test_multicast_pim_sm_topo2 test_verify_mroute_when_5_different_receiver_joining_same_sources_p0 (17.297 s)
✔️ multicast_pim_sm_topo2.test_multicast_pim_sm_topo2 test_verify_oil_iif_for_mroute_after_shut_noshut_source_interface_p1 (13.526 s)
✔️ multicast_pim_sm_topo3.test_multicast_pim_sm_topo3 test_verify_oil_when_join_prune_sent_scenario_1_p1 (44.997 s)
✔️ multicast_pim_sm_topo3.test_multicast_pim_sm_topo3 test_verify_oil_when_join_prune_sent_scenario_2_p1 (14.865 s)
✔️ multicast_pim_sm_topo3.test_multicast_pim_sm_topo3 test_shut_noshut_source_interface_when_upstream_cleared_from_LHR_p1 (13.125 s)
✔️ multicast_pim_sm_topo3.test_multicast_pim_sm_topo3 test_shut_noshut_receiver_interface_when_upstream_cleared_from_LHR_p1 (17.269 s)
✔️ multicast_pim_sm_topo3.test_multicast_pim_sm_topo3 test_verify_remove_add_igmp_config_to_receiver_interface_p0 (27.523 s)
✔️ multicast_pim_sm_topo3.test_multicast_pim_sm_topo3 test_verify_remove_add_igmp_commands_when_pim_configured_p0 (24.576 s)
✔️ multicast_pim_sm_topo3.test_multicast_pim_sm_topo3 test_verify_remove_add_pim_commands_when_igmp_configured_p1 (11.739 s)
✔️ multicast_pim_sm_topo3.test_multicast_pim_sm_topo3 test_pim_dr_priority_p0 (14.521 s)
✔️ multicast_pim_sm_topo3.test_multicast_pim_sm_topo3 test_pim_hello_timer_p1 (7.742 s)
✔️ multicast_pim_sm_topo3.test_multicast_pim_sm_topo3 test_mroute_after_removing_RP_sending_IGMP_prune_p2 (15.628 s)
✔️ multicast_pim_sm_topo3.test_multicast_pim_sm_topo3 test_prune_sent_to_LHR_and_FHR_when_PIMnbr_down_p2 (21.532 s)
✔️ multicast_pim_sm_topo3.test_multicast_pim_sm_topo3 test_mroute_flags_p1 (23.114 s)
✔️ multicast_pim_sm_topo3.test_multicast_pim_sm_topo3 test_verify_multicast_traffic_when_LHR_connected_to_RP_p1 (26.021 s)
✔️ multicast_pim_sm_topo3.test_multicast_pim_sm_topo3 test_verify_multicast_traffic_when_FHR_connected_to_RP_p1 (18.654 s)
✔️ multicast_pim_sm_topo3.test_multicast_pim_sm_topo3 test_PIM_passive_p1 (90.382 s)
✔️ multicast_pim_sm_topo3.test_multicast_pim_sm_topo4 test_mroute_when_RP_reachable_default_route_p2 (40.523 s)
✔️ multicast_pim_sm_topo3.test_multicast_pim_sm_topo4 test_mroute_with_RP_default_route_all_nodes_p2 (20.109 s)
✔️ multicast_pim_sm_topo3.test_multicast_pim_sm_topo4 test_PIM_hello_tx_rx_p1 (15.921 s)
✔️ multicast_pim_static_rp_topo1.test_multicast_pim_static_rp test_add_delete_static_RP_p0 (15.711 s)
✔️ multicast_pim_static_rp_topo1.test_multicast_pim_static_rp test_SPT_RPT_path_same_p1 (9.459 s)
✔️ multicast_pim_static_rp_topo1.test_multicast_pim_static_rp test_not_reachable_static_RP_p0 (4.687 s)
✔️ multicast_pim_static_rp_topo1.test_multicast_pim_static_rp test_add_RP_after_join_received_p1 (4.831 s)
✔️ multicast_pim_static_rp_topo1.test_multicast_pim_static_rp test_reachable_static_RP_after_join_p0 (6.946 s)
✔️ multicast_pim_static_rp_topo1.test_multicast_pim_static_rp test_send_join_on_higher_preffered_rp_p1 (7.823 s)
✔️ multicast_pim_static_rp_topo1.test_multicast_pim_static_rp1 test_RP_configured_as_LHR_1_p1 (27.755 s)
✔️ multicast_pim_static_rp_topo1.test_multicast_pim_static_rp1 test_RP_configured_as_LHR_2_p1 (6.631 s)
✔️ multicast_pim_static_rp_topo1.test_multicast_pim_static_rp1 test_RP_configured_as_FHR_1_p1 (8.787 s)
✔️ multicast_pim_static_rp_topo1.test_multicast_pim_static_rp1 test_RP_configured_as_FHR_2_p2 (6.717 s)
✔️ multicast_pim_static_rp_topo1.test_multicast_pim_static_rp1 test_SPT_RPT_path_different_p1 (7.111 s)
✔️ multicast_pim_static_rp_topo1.test_multicast_pim_static_rp1 test_clear_pim_configuration_p1 (177.094 s)
✔️ multicast_pim_static_rp_topo1.test_multicast_pim_static_rp2 test_restart_pimd_process_p2 (107.165 s)
✔️ multicast_pim_static_rp_topo1.test_multicast_pim_static_rp2 test_multiple_groups_same_RP_address_p2 (14.884 s)
✔️ multicast_pim_static_rp_topo1.test_multicast_pim_static_rp2 test_multiple_groups_different_RP_address_p2 (24.195 s)
✔️ multicast_pim_static_rp_topo1.test_multicast_pim_static_rp2 test_shutdown_primary_path_p1 (7.096 s)
✔️ multicast_pim_static_rp_topo1.test_multicast_pim_static_rp2 test_delete_RP_shut_noshut_upstream_interface_p1 (3.735 s)
✔️ multicast_pim_static_rp_topo1.test_multicast_pim_static_rp2 test_delete_RP_shut_noshut_RP_interface_p1 (7.267 s)
✔️ multicast_pim_uplink_topo1.test_multicast_pim_uplink_topo1 test_mroutes_updated_with_correct_oil_iif_when_receiver_is_in_and_outside_DUT_p0 (44.711 s)
✔️ multicast_pim_uplink_topo1.test_multicast_pim_uplink_topo1 test_mroutes_updated_with_correct_oil_iif_when_source_is_in_and_outside_DUT_p0 (66.634 s)
✔️ multicast_pim_uplink_topo1.test_multicast_pim_uplink_topo1 test_verify_mroutes_forwarding_p0 (34.877 s)
✔️ multicast_pim_uplink_topo1.test_multicast_pim_uplink_topo1 test_mroutes_updated_correctly_after_source_interface_shut_noshut_p1 (23.068 s)
✔️ multicast_pim_uplink_topo1.test_multicast_pim_uplink_topo1 test_mroutes_updated_correctly_after_receiver_interface_shut_noshut_p1 (25.896 s)
✔️ multicast_pim_uplink_topo1.test_multicast_pim_uplink_topo1 test_mroutes_updated_after_sending_IGMP_prune_and_join_p1 (20.347 s)
✔️ multicast_pim_uplink_topo1.test_multicast_pim_uplink_topo1 test_mroutes_updated_after_after_clear_mroute_p1 (9.611 s)
✔️ multicast_pim_uplink_topo1.test_multicast_pim_uplink_topo1 test_mroutes_updated_after_changing_rp_config_p1 (16.924 s)
✔️ multicast_pim_uplink_topo1.test_multicast_pim_uplink_topo1 test_mroutes_after_restart_frr_services_p2 (39.773 s)
✔️ multicast_pim_uplink_topo2.test_multicast_pim_uplink_topo2 test_iif_oil_when_RP_address_changes_from_static_to_BSR_p1 (60.589 s)
✔️ multicast_pim_uplink_topo2.test_multicast_pim_uplink_topo2 test_mroute_when_RPT_and_SPT_path_is_different_p1 (20.717 s)
✔️ multicast_pim_uplink_topo2.test_multicast_pim_uplink_topo2 test_mroutes_updated_with_correct_oil_iif_after_shut_noshut_upstream_interface_p0 (16.505 s)
✔️ multicast_pim_uplink_topo2.test_multicast_pim_uplink_topo2 test_mroutes_updated_with_correct_oil_iif_after_shut_noshut_downstream_interface_p0 (70.316 s)
✔️ multicast_pim_uplink_topo3.test_multicast_pim_uplink_topo3 test_ip_igmp_local_joins_p0 (45.256 s)
✔️ multicast_pim_uplink_topo3.test_multicast_pim_uplink_topo3 test_mroute_with_igmp_local_joins_p0 (40.897 s)
✔️ multicast_pim_uplink_topo3.test_multicast_pim_uplink_topo3 test_igmp_local_join_with_reserved_address_p0 (6.720 s)
✔️ multicast_pim_uplink_topo3.test_multicast_pim_uplink_topo3 test_remove_add_igmp_local_joins_p1 (18.934 s)